-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #5344, Fix Part of #5422 and Fix Part of #5012: Implement Classroom List Screen with Jetpack Compose #5437
Conversation
… classroom. IDs of Science & Maths classrooms is interchanged to make the relative ordering of the topics same as previous. This is required by several UI tests to pass.
Noticed bazel builds timing out so I have cancelled the workflow |
Yep, thanks, I was going to do so. Also, have re-run the builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17. This Looks Good to me.
@theMr17 Please reasign once the PR description is complete. |
Assigning @BenHenning for code owner reviews. Thanks! |
@adhiamboperes I've updated the PR title and description. I hope I haven't missed anything. |
@seanlip, this PR is ready to be merged. I am updating with develop and enabling automerge. PTAL for owners. |
Closing and reopening to trigger CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for owners.
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 18 MiB (new), 2618 KiB (Added) APK download size (estimated): 14 MiB (old), 17 MiB (new), 2614 KiB (Added) Method count: 227007 (old), 257693 (new), 30686 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6550 (old), 6646 (new), 96 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 18 MiB (new), 2673 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 49 KiB (new), 9988 bytes (Removed)
Configuration ldpiAPK file size: 56 KiB (old), 48 KiB (new), 8316 bytes (Removed)
Configuration mdpiAPK file size: 53 KiB (old), 45 KiB (new), 8384 bytes (Removed)
Configuration tvdpiAPK file size: 102 KiB (old), 85 KiB (new), 17 KiB (Removed)
Configuration xhdpiAPK file size: 67 KiB (old), 56 KiB (new), 10 KiB (Removed)
Configuration xxhdpiAPK file size: 76 KiB (old), 62 KiB (new), 13 KiB (Removed)
Configuration xxxhdpiAPK file size: 79 KiB (old), 63 KiB (new), 15 KiB (Removed)
AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 925 KiB (Added) APK download size (estimated): 9184 KiB (old), 9 MiB (new), 918 KiB (Added) Method count: 101341 (old), 114371 (new), 13030 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5613 (new), 109 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 10 MiB (new), 981 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 42 KiB (new), 9 KiB (Removed)
Configuration ldpiAPK file size: 52 KiB (old), 44 KiB (new), 8364 bytes (Removed)
Configuration mdpiAPK file size: 46 KiB (old), 38 KiB (new), 8500 bytes (Removed)
Configuration tvdpiAPK file size: 90 KiB (old), 72 KiB (new), 17 KiB (Removed)
Configuration xhdpiAPK file size: 60 KiB (old), 49 KiB (new), 10 KiB (Removed)
Configuration xxhdpiAPK file size: 69 KiB (old), 55 KiB (new), 13 KiB (Removed)
Configuration xxxhdpiAPK file size: 71 KiB (old), 55 KiB (new), 16 KiB (Removed)
BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 923 KiB (Added) APK download size (estimated): 9169 KiB (old), 9 MiB (new), 915 KiB (Added) Method count: 101341 (old), 114377 (new), 13036 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5613 (new), 109 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 10 MiB (new), 979 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 42 KiB (new), 9 KiB (Removed)
Configuration ldpiAPK file size: 52 KiB (old), 44 KiB (new), 8364 bytes (Removed)
Configuration mdpiAPK file size: 46 KiB (old), 38 KiB (new), 8500 bytes (Removed)
Configuration tvdpiAPK file size: 90 KiB (old), 72 KiB (new), 17 KiB (Removed)
Configuration xhdpiAPK file size: 60 KiB (old), 49 KiB (new), 10 KiB (Removed)
Configuration xxhdpiAPK file size: 69 KiB (old), 55 KiB (new), 13 KiB (Removed)
Configuration xxxhdpiAPK file size: 71 KiB (old), 55 KiB (new), 16 KiB (Removed)
GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 923 KiB (Added) APK download size (estimated): 9169 KiB (old), 9 MiB (new), 917 KiB (Added) Method count: 101341 (old), 114377 (new), 13036 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5613 (new), 109 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 10 MiB (new), 979 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 42 KiB (new), 9 KiB (Removed)
Configuration ldpiAPK file size: 52 KiB (old), 44 KiB (new), 8364 bytes (Removed)
Configuration mdpiAPK file size: 46 KiB (old), 38 KiB (new), 8500 bytes (Removed)
Configuration tvdpiAPK file size: 90 KiB (old), 72 KiB (new), 17 KiB (Removed)
Configuration xhdpiAPK file size: 60 KiB (old), 49 KiB (new), 10 KiB (Removed)
Configuration xxhdpiAPK file size: 69 KiB (old), 55 KiB (new), 13 KiB (Removed)
Configuration xxxhdpiAPK file size: 71 KiB (old), 55 KiB (new), 16 KiB (Removed)
|
Explanation
Fixes part of #5344
Fixes part of #5422
Fixes part of #5012
This PR introduces the Classroom List Screen, which will replace the existing Home Screen. The new screen features a classroom carousel that remains sticky when the screen is scrolled. Various approaches were considered for implementing the sticky header, as detailed in Decision 3: How to implement the sticky classroom carousel?. Ultimately, it was decided to use the
stickyHeader
component of Jetpack Compose.ComposeView
to host the composable components. Appropriate tests have been set up to verify the functionality.onActivityResult
- Deprecates the use ofonActivityResult
and transitions to usingActivityResultContracts
for handling activity results.minSdkVersion
to be atleast 21. This PR initiates the process of deprecating support for Android 19 (KitKat).ScreenRecording.mp4
Screenshots
Phone Light Mode
Phone Dark Mode
Tablet Light Mode
Tablet Dark Mode
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: