Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Part of #4938: Introduce Onboarding Intro screen #5385

Merged
merged 163 commits into from
Jun 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
163 commits
Select commit Hold shift + click to select a range
5d86f13
Add drawable resources
adhiamboperes Mar 27, 2024
a17713d
Make SurveyOnboardingBackgroundView generic for reuse.
adhiamboperes Mar 27, 2024
7c11bcd
Create app language selection UI
adhiamboperes Mar 27, 2024
722c759
Add tests for the new app language screen
adhiamboperes Mar 27, 2024
0a24f11
Fix UI
adhiamboperes Mar 27, 2024
1462eb7
Fix buildifier issue
adhiamboperes Mar 27, 2024
a337b9b
Merge remote-tracking branch 'upstream/new-onboarding-screen' into on…
adhiamboperes Apr 2, 2024
785716e
Add OnboardingProfileTypeActivity
adhiamboperes Apr 3, 2024
3067ff2
Add drawable resources
adhiamboperes Apr 3, 2024
5a41256
Add profile type selection UI with navigation.
adhiamboperes Apr 3, 2024
40d188f
Add tests
adhiamboperes Apr 3, 2024
434d9dc
Add test file exemptions
adhiamboperes Apr 3, 2024
5bd5239
Fix ktlint issue
adhiamboperes Apr 3, 2024
5fb890e
Addressed general feedback
adhiamboperes Apr 3, 2024
adbdbed
Fix curve background for landscape orientation
adhiamboperes Apr 3, 2024
4f0c57b
Flatten Bg drawable
adhiamboperes Apr 3, 2024
187726c
Merge branch 'develop' of github.com:oppia/oppia-android into new-onb…
adhiamboperes Apr 3, 2024
3d2313c
Merge remote-tracking branch 'upstream/new-onboarding-screen' into on…
adhiamboperes Apr 3, 2024
352bf33
Merge branch 'onboarding-profile-type-screen' into create-profile-screen
adhiamboperes Apr 9, 2024
75c39bc
Create CreateProfileActivity
adhiamboperes Apr 9, 2024
125a408
Create CreateProfileFragment
adhiamboperes Apr 9, 2024
cf1f68f
Navigate to CreateProfileActivity
adhiamboperes Apr 9, 2024
eebf64d
Fix ktlint failures
adhiamboperes Apr 9, 2024
027d912
Add tests
adhiamboperes Apr 9, 2024
0d7980f
Add tests for profile picture upload
adhiamboperes Apr 9, 2024
312fc38
Add layout for tablets
adhiamboperes Apr 9, 2024
6ccba79
Fix self review comments
adhiamboperes Apr 9, 2024
0bc5547
Merge branch 'develop' into new-onboarding-screen
adhiamboperes Apr 9, 2024
f31e23d
Create tablet layouts and darkmode bg
adhiamboperes Apr 9, 2024
3e6c7b3
Merge branch 'new-onboarding-screen' of github.com:oppia/oppia-androi…
adhiamboperes Apr 9, 2024
f1d9092
Fix formatting
adhiamboperes Apr 9, 2024
3e2166e
Fix failing test
adhiamboperes Apr 9, 2024
fc452fc
Merge remote-tracking branch 'upstream/onboarding-profile-type-screen…
adhiamboperes Apr 9, 2024
98fcfe6
Fix failing test
adhiamboperes Apr 9, 2024
ccca3a4
Fix missing bazel declaration for CreateProfileViewModel
adhiamboperes Apr 9, 2024
5d052e4
Fix missing bazel declaration for CreateProfileViewModel
adhiamboperes Apr 9, 2024
ff6488b
Create onboarding intro activity
adhiamboperes Apr 10, 2024
dae1afd
Create onboarding intro fragment
adhiamboperes Apr 10, 2024
b2c9a0c
Add navigation to intro activity
adhiamboperes Apr 10, 2024
94329f0
Create mobile landscape layout
adhiamboperes Apr 10, 2024
8a07fdd
Create tablet layouts
adhiamboperes Apr 10, 2024
b708f88
Add tests
adhiamboperes Apr 10, 2024
8aa9320
Ktlint errors
adhiamboperes Apr 10, 2024
3b4e235
Fix paint style for OppiaCurveBackgroundView.kt
adhiamboperes Apr 17, 2024
b7935e1
Merge branch 'develop' of github.com:oppia/oppia-android into new-onb…
adhiamboperes Apr 17, 2024
b722e49
Merge branch 'new-onboarding-screen' of github.com:oppia/oppia-androi…
adhiamboperes Apr 17, 2024
8f7e355
Adjust height of the otter drawable
adhiamboperes Apr 17, 2024
b411179
Improve styling for phone layouts
adhiamboperes May 22, 2024
bad32c5
Improve styling for tablet layouts
adhiamboperes May 22, 2024
7345107
Clean up padding and text size dimensions
adhiamboperes May 22, 2024
30b26e0
Clean up padding and text size dimensions
adhiamboperes May 22, 2024
2c10cd2
Remove space
adhiamboperes May 22, 2024
3d7cf86
Fix failing test
adhiamboperes May 22, 2024
e67a2f0
Merge branch 'new-onboarding-screen' into onboarding-profile-type-screen
adhiamboperes May 23, 2024
4f53fb5
Update styling
adhiamboperes May 23, 2024
70fac4a
Remove unnecessary tests
adhiamboperes May 23, 2024
8d5c408
Fix indentation
adhiamboperes May 23, 2024
73874b8
Fix general review comments
adhiamboperes May 23, 2024
9547f8d
Create style for back navigation button
adhiamboperes May 23, 2024
cd54544
Fix mobile landscape layout
adhiamboperes May 23, 2024
16c9a97
Fix tests and add tests for mobile landscape layout
adhiamboperes May 23, 2024
0ea7456
Fix ktlint
adhiamboperes May 23, 2024
076c7f0
Fix ktlint
adhiamboperes May 23, 2024
ca2fbfe
Merge branch 'onboarding-profile-type-screen' into create-profile-screen
adhiamboperes May 23, 2024
ab2ee84
Improve phone layout styling
adhiamboperes May 23, 2024
b2bc62d
Improve tablet layout styling
adhiamboperes May 23, 2024
8e5ac97
Fix tests
adhiamboperes May 23, 2024
827afae
Flatten the activity layout
adhiamboperes May 23, 2024
114ae78
Revert formatting changes in the styles file
adhiamboperes May 23, 2024
fde105c
Merge branch 'develop' of github.com:oppia/oppia-android into new-onb…
adhiamboperes May 23, 2024
01c45af
Merge branch 'new-onboarding-screen' into onboarding-profile-type-screen
adhiamboperes May 23, 2024
0bdd447
Fix margin and update with develop
adhiamboperes May 24, 2024
1a4ae23
Merge remote-tracking branch 'upstream/onboarding-profile-type-screen…
adhiamboperes May 24, 2024
497d35b
Fix missing kdoc
adhiamboperes May 24, 2024
9dcf007
Fix kdoc
adhiamboperes May 24, 2024
72ee395
Merge branch 'create-profile-screen' into onboarding-learner-intro-sc…
adhiamboperes May 24, 2024
5452751
Sync and polish UI
adhiamboperes May 25, 2024
1031657
Flatten Layout
adhiamboperes May 25, 2024
acc6067
Fix ktlint
adhiamboperes May 25, 2024
bbe7221
Refactor existing OnboardingFragmentPresenter to OnboardingFragmentPr…
adhiamboperes May 28, 2024
05f598d
Refactor the dropdown
adhiamboperes May 31, 2024
6565d73
Refactor the dropdown in alternate layouts
adhiamboperes May 31, 2024
d67f5ed
Refactor custom background to a binding adapter
adhiamboperes Jun 2, 2024
7c69c15
Fix failing tests and set up bazel test
adhiamboperes Jun 2, 2024
0a7c600
Merge remote-tracking branch 'upstream/develop' into new-onboarding-s…
adhiamboperes Jun 2, 2024
1c0494f
Fix ktlint
adhiamboperes Jun 2, 2024
a8c207a
Replace otter png with SVG
adhiamboperes Jun 3, 2024
1172ff6
Fix failing tests and general cleanup
adhiamboperes Jun 3, 2024
4612e6b
Fix test file exemption
adhiamboperes Jun 3, 2024
d3451ab
Fix accessibility label exemption
adhiamboperes Jun 3, 2024
6095c54
Fix drawable vector hex exemption
adhiamboperes Jun 3, 2024
2540989
Fix unused exemption
adhiamboperes Jun 3, 2024
65d9f11
Fix failing test
adhiamboperes Jun 3, 2024
3bf91c3
Move files to onboarding package
adhiamboperes Jun 3, 2024
18ba375
Merge remote-tracking branch 'upstream/new-onboarding-screen' into on…
adhiamboperes Jun 3, 2024
05d05f1
Resolve merge conflicts
adhiamboperes Jun 3, 2024
1067e57
Added oxford comma
adhiamboperes Jun 3, 2024
e79b69b
Removed leftover exemption
adhiamboperes Jun 3, 2024
c694f51
Fix tests
adhiamboperes Jun 3, 2024
12fbcad
Fix static check errors
adhiamboperes Jun 4, 2024
56f2998
Move everything to onboarding package
adhiamboperes Jun 4, 2024
3fe2539
Merge remote-tracking branch 'upstream/onboarding-profile-type-screen…
adhiamboperes Jun 4, 2024
d955011
Address initial review comments + pull in changes from upstream
adhiamboperes Jun 4, 2024
7286c86
Address styling suggestions
adhiamboperes Jun 4, 2024
787c3f1
Add textwatcher to name edittext
adhiamboperes Jun 4, 2024
2d895c0
Switch to glide util
adhiamboperes Jun 4, 2024
26b7f1e
Add test for image loading
adhiamboperes Jun 4, 2024
e39cd19
Add test for image loading
adhiamboperes Jun 4, 2024
c9f4d82
Fix script check failures
adhiamboperes Jun 4, 2024
c23baab
Fix missing build input
adhiamboperes Jun 4, 2024
90d56c1
Fix script check failures
adhiamboperes Jun 4, 2024
b11d00f
Move files to onboarding package
adhiamboperes Jun 4, 2024
7c34ab9
Merge remote-tracking branch 'upstream/create-profile-screen' into on…
adhiamboperes Jun 4, 2024
b458e19
Fix forward databinding error from upstream
adhiamboperes Jun 5, 2024
1a77d9c
Add forward navigation
adhiamboperes Jun 5, 2024
b542733
Remove modules from upstream
adhiamboperes Jun 5, 2024
a6ee4f5
Add navigation tests
adhiamboperes Jun 5, 2024
fac5719
Fix alignment on tablet landscape
adhiamboperes Jun 5, 2024
f14bbb1
Merge remote-tracking branch 'upstream/develop' into new-onboarding-s…
adhiamboperes Jun 11, 2024
ea056af
Merge branch 'new-onboarding-screen' into onboarding-profile-type-screen
adhiamboperes Jun 11, 2024
5237f63
Merge remote-tracking branch 'upstream/onboarding-profile-type-screen…
adhiamboperes Jun 11, 2024
3fdf74f
Fix merge conflict
adhiamboperes Jun 11, 2024
c2c244b
Merge branch 'new-onboarding-screen' into onboarding-profile-type-screen
adhiamboperes Jun 11, 2024
b802921
Merge branch 'onboarding-profile-type-screen' into create-profile-screen
adhiamboperes Jun 11, 2024
66b664c
Merge branch 'create-profile-screen' into onboarding-learner-intro-sc…
adhiamboperes Jun 11, 2024
a435c11
Create new style for error messages
adhiamboperes Jun 11, 2024
3f3b810
Add textwatcher test
adhiamboperes Jun 11, 2024
5b3ecba
Fix small issues
adhiamboperes Jun 11, 2024
5b43705
Fix small issues
adhiamboperes Jun 11, 2024
43274da
Merge branch 'create-profile-screen' into onboarding-learner-intro-sc…
adhiamboperes Jun 11, 2024
1d7f954
Fix merge conflicts
adhiamboperes Jun 11, 2024
72624f5
Merge branch 'develop' into new-onboarding-screen
adhiamboperes Jun 17, 2024
13d9ac5
Merge branch 'new-onboarding-screen' into onboarding-profile-type-screen
adhiamboperes Jun 17, 2024
f0d0c57
Merge branch 'onboarding-profile-type-screen' into create-profile-screen
adhiamboperes Jun 17, 2024
199447d
Merge branch 'create-profile-screen' into onboarding-learner-intro-sc…
adhiamboperes Jun 17, 2024
485dc54
Replace Lifecycle.State check with activity.isFinishing
adhiamboperes Jun 18, 2024
33624d7
Flatten layout
adhiamboperes Jun 19, 2024
2b10f80
Resolve merge conflicts
adhiamboperes Jun 19, 2024
1ade253
Merge branch 'onboarding-profile-type-screen' into create-profile-screen
adhiamboperes Jun 19, 2024
49586cc
Adjust profile picture prompt
adhiamboperes Jun 19, 2024
2d5d438
Add assertions for image loaded
adhiamboperes Jun 19, 2024
41dea0b
Replace Lifecycle.State check with activity.isFinishing
adhiamboperes Jun 19, 2024
e6a1b24
Addressed reviewer comments
adhiamboperes Jun 19, 2024
85081cc
Merge branch 'create-profile-screen' into onboarding-learner-intro-sc…
adhiamboperes Jun 19, 2024
1bb7508
Merge branch 'develop' into onboarding-profile-type-screen
adhiamboperes Jun 24, 2024
6e0401f
Update test_file_exemptions to the new format
adhiamboperes Jun 24, 2024
2f84098
Fix indent
adhiamboperes Jun 24, 2024
d979d1b
Merge branch 'onboarding-profile-type-screen' into create-profile-screen
adhiamboperes Jun 24, 2024
2d83378
Update test_file_exemptions
adhiamboperes Jun 24, 2024
3f5c8c2
Merge branch 'create-profile-screen' into onboarding-learner-intro-sc…
adhiamboperes Jun 24, 2024
e3565b5
Address reviewer comment
adhiamboperes Jun 24, 2024
04acfa9
Merge branch 'develop' into onboarding-profile-type-screen
adhiamboperes Jun 30, 2024
223150b
Replace png images with svgs
adhiamboperes Jun 30, 2024
90428af
Add exemptions for new svgs
adhiamboperes Jun 30, 2024
e248fb1
Pull upstream and fix conflicts
adhiamboperes Jun 30, 2024
9fd9fbc
Change default avatar bg in v2
adhiamboperes Jun 30, 2024
2ec249d
Fix profile prompt background
adhiamboperes Jun 30, 2024
988ab47
Merge branch 'develop' into create-profile-screen
adhiamboperes Jun 30, 2024
af6ed95
Fix deprecated api
adhiamboperes Jun 30, 2024
53e7b9b
Merge branch 'create-profile-screen' into onboarding-learner-intro-sc…
adhiamboperes Jun 30, 2024
05d02c3
Fix kdoc
adhiamboperes Jun 30, 2024
ce9660d
Merge branch 'create-profile-screen' into onboarding-learner-intro-sc…
adhiamboperes Jun 30, 2024
b4aec16
Merge branch 'develop' into onboarding-learner-intro-screen
adhiamboperes Jun 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,10 @@
android:name=".app.onboarding.CreateProfileActivity"
android:label="@string/create_profile_activity_title"
android:theme="@style/OppiaThemeWithoutActionBar" />
<activity
android:name=".app.onboarding.IntroActivity"
android:label="@string/onboarding_learner_intro_activity_title"
android:theme="@style/OppiaThemeWithoutActionBar" />
<provider
android:name="androidx.work.impl.WorkManagerInitializer"
android:authorities="${applicationId}.workmanager-init"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import org.oppia.android.app.home.HomeActivity
import org.oppia.android.app.home.recentlyplayed.RecentlyPlayedActivity
import org.oppia.android.app.mydownloads.MyDownloadsActivity
import org.oppia.android.app.onboarding.CreateProfileActivity
import org.oppia.android.app.onboarding.IntroActivity
import org.oppia.android.app.onboarding.OnboardingActivity
import org.oppia.android.app.onboarding.OnboardingProfileTypeActivity
import org.oppia.android.app.ongoingtopiclist.OngoingTopicListActivity
Expand Down Expand Up @@ -224,4 +225,5 @@ interface ActivityComponentImpl :
fun inject(classroomListActivity: ClassroomListActivity)
fun inject(onboardingProfileTypeActivity: OnboardingProfileTypeActivity)
fun inject(createProfileActivity: CreateProfileActivity)
fun inject(introActivity: IntroActivity)
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import org.oppia.android.app.notice.GeneralAvailabilityUpgradeNoticeDialogFragme
import org.oppia.android.app.notice.OptionalAppDeprecationNoticeDialogFragment
import org.oppia.android.app.notice.OsDeprecationNoticeDialogFragment
import org.oppia.android.app.onboarding.CreateProfileFragment
import org.oppia.android.app.onboarding.IntroFragment
import org.oppia.android.app.onboarding.OnboardingFragment
import org.oppia.android.app.onboarding.OnboardingProfileTypeFragment
import org.oppia.android.app.ongoingtopiclist.OngoingTopicListFragment
Expand Down Expand Up @@ -200,4 +201,5 @@ interface FragmentComponentImpl : FragmentComponent, ViewComponentBuilderInjecto
fun inject(classroomListFragment: ClassroomListFragment)
fun inject(onboardingProfileTypeFragment: OnboardingProfileTypeFragment)
fun inject(createProfileFragment: CreateProfileFragment)
fun inject(introFragment: IntroFragment)
}
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ class CreateProfileFragmentPresenter @Inject constructor(
val nickname = binding.createProfileNicknameEdittext.text.toString().trim()

createProfileViewModel.hasErrorMessage.set(nickname.isBlank())

if (createProfileViewModel.hasErrorMessage.get() != true) {
val intent = IntroActivity.createIntroActivity(activity, nickname)
fragment.startActivity(intent)
}
}

binding.createProfileNicknameEdittext.addTextChangedListener(object : TextWatcher {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
package org.oppia.android.app.onboarding

import android.content.Context
import android.content.Intent
import android.os.Bundle
import org.oppia.android.app.activity.ActivityComponentImpl
import org.oppia.android.app.activity.InjectableAutoLocalizedAppCompatActivity
import org.oppia.android.app.model.IntroActivityParams
import org.oppia.android.app.model.ScreenName.INTRO_ACTIVITY
import org.oppia.android.util.extensions.getProtoExtra
import org.oppia.android.util.extensions.putProtoExtra
import org.oppia.android.util.logging.CurrentAppScreenNameIntentDecorator.decorateWithScreenName
import javax.inject.Inject

/** The activity for showing the learner welcome screen. */
class IntroActivity : InjectableAutoLocalizedAppCompatActivity() {
@Inject
lateinit var onboardingLearnerIntroActivityPresenter: IntroActivityPresenter

private lateinit var profileNickname: String

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
(activityComponent as ActivityComponentImpl).inject(this)

val params = intent.extractParams()
this.profileNickname = params.profileNickname

onboardingLearnerIntroActivityPresenter.handleOnCreate(profileNickname)
}

companion object {
private const val PARAMS_KEY = "OnboardingIntroActivity.params"

/**
* A convenience function for creating a new [OnboardingLearnerIntroActivity] intent by prefilling
* common params needed by the activity.
*/
fun createIntroActivity(context: Context, profileNickname: String): Intent {
val params = IntroActivityParams.newBuilder()
.setProfileNickname(profileNickname)
.build()
return createOnboardingLearnerIntroActivity(context, params)
}

private fun createOnboardingLearnerIntroActivity(
context: Context,
params: IntroActivityParams
): Intent {
return Intent(context, IntroActivity::class.java).apply {
putProtoExtra(PARAMS_KEY, params)
decorateWithScreenName(INTRO_ACTIVITY)
}
}

private fun Intent.extractParams() =
getProtoExtra(PARAMS_KEY, IntroActivityParams.getDefaultInstance())
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
package org.oppia.android.app.onboarding

import android.os.Bundle
import androidx.appcompat.app.AppCompatActivity
import androidx.databinding.DataBindingUtil
import org.oppia.android.R
import org.oppia.android.app.activity.ActivityScope
import org.oppia.android.databinding.IntroActivityBinding
import javax.inject.Inject

private const val TAG_LEARNER_INTRO_FRAGMENT = "TAG_INTRO_FRAGMENT"

/** Argument key for bundling the profileId. */
const val PROFILE_NICKNAME_ARGUMENT_KEY = "profile_nickname"

/** The Presenter for [IntroActivity]. */
@ActivityScope
class IntroActivityPresenter @Inject constructor(
private val activity: AppCompatActivity
) {
private lateinit var binding: IntroActivityBinding

/** Handle creation and binding of the [IntroActivity] layout. */
fun handleOnCreate(profileNickname: String) {
binding = DataBindingUtil.setContentView(activity, R.layout.intro_activity)
binding.lifecycleOwner = activity

if (getIntroFragment() == null) {
val introFragment = IntroFragment()

val args = Bundle()
args.putString(PROFILE_NICKNAME_ARGUMENT_KEY, profileNickname)
introFragment.arguments = args

activity.supportFragmentManager.beginTransaction().add(
R.id.learner_intro_fragment_placeholder,
introFragment,
TAG_LEARNER_INTRO_FRAGMENT
)
.commitNow()
}
}

private fun getIntroFragment(): IntroFragment? {
return activity.supportFragmentManager.findFragmentByTag(
TAG_LEARNER_INTRO_FRAGMENT
) as? IntroFragment
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package org.oppia.android.app.onboarding

import android.content.Context
import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import org.oppia.android.app.fragment.FragmentComponentImpl
import org.oppia.android.app.fragment.InjectableFragment
import org.oppia.android.util.extensions.getStringFromBundle
import javax.inject.Inject

/** Fragment that contains the introduction message for new learners. */
class IntroFragment : InjectableFragment() {
@Inject
lateinit var introFragmentPresenter: IntroFragmentPresenter

override fun onAttach(context: Context) {
super.onAttach(context)
(fragmentComponent as FragmentComponentImpl).inject(this)
}

override fun onCreateView(
inflater: LayoutInflater,
container: ViewGroup?,
savedInstanceState: Bundle?
): View? {
val profileNickname =
checkNotNull(arguments?.getStringFromBundle(PROFILE_NICKNAME_ARGUMENT_KEY)) {
"Expected profileNickname to be included in the arguments for IntroFragment."
}
return introFragmentPresenter.handleCreateView(
inflater,
container,
profileNickname
)
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
package org.oppia.android.app.onboarding

import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.appcompat.app.AppCompatActivity
import androidx.fragment.app.Fragment
import org.oppia.android.R
import org.oppia.android.app.translation.AppLanguageResourceHandler
import org.oppia.android.databinding.LearnerIntroFragmentBinding
import javax.inject.Inject

/** The presenter for [IntroFragment]. */
class IntroFragmentPresenter @Inject constructor(
private var fragment: Fragment,
private val activity: AppCompatActivity,
private val appLanguageResourceHandler: AppLanguageResourceHandler,
) {
private lateinit var binding: LearnerIntroFragmentBinding

/** Handle creation and binding of the OnboardingLearnerIntroFragment layout. */
fun handleCreateView(
inflater: LayoutInflater,
container: ViewGroup?,
profileNickname: String,
): View {
binding = LearnerIntroFragmentBinding.inflate(
inflater,
container,
/* attachToRoot= */ false
)
binding.lifecycleOwner = fragment

setLearnerName(profileNickname)

binding.onboardingNavigationBack.setOnClickListener {
activity.finish()
}

binding.onboardingLearnerIntroFeedback.text =
appLanguageResourceHandler.getStringInLocaleWithWrapping(
R.string.onboarding_learner_intro_feedback_text,
appLanguageResourceHandler.getStringInLocale(R.string.app_name)
)

return binding.root
}

private fun setLearnerName(profileName: String) {
binding.onboardingLearnerIntroTitle.text =
appLanguageResourceHandler.getStringInLocaleWithWrapping(
R.string.onboarding_learner_intro_activity_text, profileName
)
}
}
9 changes: 9 additions & 0 deletions app/src/main/res/drawable/ic_green_check.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="20dp"
android:height="20dp"
android:viewportWidth="20"
android:viewportHeight="20">
<path
android:pathData="M0,13.5385C0.1907,13.9557 0.5447,14.2878 0.8361,14.6375C1.32,15.2186 1.7995,15.8019 2.2679,16.396C2.8501,17.1343 3.6537,18.3712 4.1667,19.1616C4.3932,19.5105 4.4232,19.696 4.7823,19.9109C4.9976,20.0397 5.3221,19.9862 5.5614,19.9862H7.3671C7.5963,19.9862 7.9821,20.0594 8.1554,19.8687C8.4929,19.4973 8.6357,18.6971 8.8161,18.2277C9.1803,17.2804 9.6335,16.3627 10.061,15.4435C11.3427,12.6875 12.9254,10.0628 14.5898,7.5304C15.7954,5.696 17.1571,3.8561 18.7724,2.3716C19.2131,1.9667 20.3897,1.2326 19.87,0.5122C19.6045,0.1443 19.0427,0.0956 18.6344,0.0371C17.1884,-0.1701 15.7418,0.5127 14.7342,1.5226C12.207,4.0557 10.39,7.1461 8.5007,10.1681C7.9992,10.9704 7.5674,11.8236 7.1234,12.6593C6.9651,12.9573 6.7927,13.5016 6.485,13.6691C6.2234,13.8114 5.8627,13.6406 5.6337,13.5033C4.9993,13.1227 4.5233,12.5324 4.1086,11.9266C3.9712,11.7258 3.8034,11.3051 3.5324,11.2688C3.2105,11.2257 2.7761,11.6711 2.5279,11.8413C1.698,12.4104 0.8749,13.0444 0,13.5385Z"
android:fillColor="#00645C"/>
</vector>
96 changes: 96 additions & 0 deletions app/src/main/res/layout-land/learner_intro_fragment.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
<?xml version="1.0" encoding="utf-8"?>
<layout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto">

<androidx.constraintlayout.widget.ConstraintLayout
android:layout_width="match_parent"
android:layout_height="match_parent"
android:background="@color/component_color_onboarding_learner_intro_background_color">

<TextView
android:id="@+id/onboarding_learner_intro_title"
style="@style/OnboardingHeaderStyle"
android:layout_marginTop="@dimen/phone_shared_margin_large"
android:text="@string/onboarding_learner_intro_activity_text"
android:textColor="@color/component_color_onboarding_learner_intro_header_color"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />

<com.google.android.material.textview.MaterialTextView
android:id="@+id/onboarding_learner_intro_classroom"
style="@style/OnboardingLearnerIntroBulletsStyle"
android:layout_marginTop="@dimen/phone_shared_margin_medium"
android:text="@string/onboarding_learner_intro_classroom_text"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintWidth_percent="0.7"
app:layout_constraintTop_toBottomOf="@id/onboarding_learner_intro_title" />

<com.google.android.material.textview.MaterialTextView
android:id="@+id/onboarding_learner_intro_practice"
style="@style/OnboardingLearnerIntroBulletsStyle"
android:layout_marginTop="@dimen/phone_shared_margin_small"
android:text="@string/onboarding_learner_intro_practice_text"
app:layout_constraintStart_toStartOf="@id/onboarding_learner_intro_classroom"
app:layout_constraintTop_toBottomOf="@id/onboarding_learner_intro_classroom" />

<com.google.android.material.textview.MaterialTextView
android:id="@+id/onboarding_learner_intro_feedback"
style="@style/OnboardingLearnerIntroBulletsStyle"
android:layout_marginTop="@dimen/phone_shared_margin_small"
android:text="@string/onboarding_learner_intro_feedback_text"
app:layout_constraintStart_toStartOf="@id/onboarding_learner_intro_classroom"
app:layout_constraintTop_toBottomOf="@id/onboarding_learner_intro_practice" />

<androidx.constraintlayout.widget.Guideline
android:id="@+id/learner_intro_center_guide"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:orientation="horizontal"
app:layout_constraintGuide_percent="0.50" />

<org.oppia.android.app.customview.OppiaCurveBackgroundView
android:id="@+id/onboarding_learner_intro_background"
android:layout_width="match_parent"
android:layout_height="0dp"
app:customBackgroundColor="@{@color/component_color_onboarding_shared_white_color}"
app:layout_constraintTop_toBottomOf="@id/learner_intro_center_guide" />

<ImageView
android:id="@+id/learner_intro_otter_imageview"
android:layout_width="wrap_content"
android:layout_height="112dp"
android:layout_marginTop="@dimen/phone_shared_margin_xl"
android:contentDescription="@string/onboarding_otter_content_description"
app:layout_constraintEnd_toStartOf="@id/onboarding_navigation_continue"
app:layout_constraintStart_toEndOf="@id/onboarding_navigation_back"
app:layout_constraintTop_toBottomOf="@id/learner_intro_center_guide"
app:srcCompat="@drawable/otter" />

<Button
android:id="@+id/onboarding_navigation_back"
style="@style/OnboardingNavigationSecondaryButton"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/onboarding_navigation_back"
android:layout_marginStart="@dimen/phone_shared_margin_medium"
android:layout_marginBottom="@dimen/phone_shared_margin_medium"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@id/onboarding_navigation_continue"
app:layout_constraintHorizontal_chainStyle="spread_inside"
app:layout_constraintStart_toStartOf="parent" />

<Button
android:id="@+id/onboarding_navigation_continue"
style="@style/OnboardingNavigationPrimaryButton"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/onboarding_navigation_continue"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
android:layout_marginEnd="@dimen/phone_shared_margin_medium"
android:layout_marginBottom="@dimen/phone_shared_margin_medium"
app:layout_constraintStart_toEndOf="@id/onboarding_navigation_back" />
</androidx.constraintlayout.widget.ConstraintLayout>
</layout>
Loading
Loading