Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4938: Revised Profile Configuration 3 of 3 #5328

Closed
wants to merge 8 commits into from
Closed

Fix #4938: Revised Profile Configuration 3 of 3 #5328

wants to merge 8 commits into from

Conversation

adhiamboperes
Copy link
Collaborator

@adhiamboperes adhiamboperes commented Jan 31, 2024 •
edited
Loading

Explanation

Fix Part of #4938: New profile configuration and existing profile migration.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@adhiamboperes
Merge remote-tracking branch 'upstream/new-onboarding-platform-param'…
ae015a5 
… into onboarding-profile-configuration

# Conflicts:
#	domain/src/main/java/org/oppia/android/domain/platformparameter/PlatformParameterAlphaKenyaModule.kt
#	domain/src/main/java/org/oppia/android/domain/platformparameter/PlatformParameterAlphaModule.kt
#	domain/src/main/java/org/oppia/android/domain/platformparameter/PlatformParameterModule.kt
#	testing/src/main/java/org/oppia/android/testing/platformparameter/TestPlatformParameterModule.kt
@adhiamboperes
Create new profile proto models
9192df2
@adhiamboperes
Plug in new onboarding and profile configuration logic
6237fbb
@adhiamboperes
Merge branch 'new-onboarding-ui' into onboarding-profile-configuration
ea08ccb 
# Conflicts:
#	domain/src/main/java/org/oppia/android/domain/platformparameter/PlatformParameterAlphaKenyaModule.kt
#	domain/src/main/java/org/oppia/android/domain/platformparameter/PlatformParameterAlphaModule.kt
#	domain/src/main/java/org/oppia/android/domain/platformparameter/PlatformParameterModule.kt
#	testing/src/main/java/org/oppia/android/testing/platformparameter/TestPlatformParameterModule.kt
@adhiamboperes adhiamboperes self-assigned this Jan 31, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Feb 7, 2024

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 7, 2024
@adhiamboperes adhiamboperes removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 9, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Feb 16, 2024

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 16, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Feb 16, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Feb 23, 2024

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot OppiaBot
Copy link

oppiabot bot commented Mar 6, 2024

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 6, 2024
@oppiabot oppiabot bot closed this Mar 13, 2024
@adhiamboperes adhiamboperes deleted the onboarding-profile-configuration branch July 9, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adhiamboperes adhiamboperes

Labels
stale Corresponds to items that haven't seen a recent update and may be automatically closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adhiamboperes