-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Part of #4938: Introduce Onboarding UI V2 2 of 3 #5327
Conversation
…kgroundView Since many new designs include this custom shape, we can now reuse this view by passing in the desired background color.
… into new-onboarding-ui # Conflicts: # app/src/main/res/values/dimens.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First self-review pass.
app/src/main/java/org/oppia/android/app/onboarding/OnboardingFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/org/oppia/android/app/onboarding/onboardingv2/AudioLanguageFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/onboarding/OnboardingFragmentTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second self-review pass.
app/src/main/res/drawable/onboarding_back_button_white_background.xml
Outdated
Show resolved
Hide resolved
...rc/main/java/org/oppia/android/app/onboarding/onboardingv2/AudioLanguageFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
…to new-onboarding-ui
audio and new profile
Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another self-review pass. Some refactors and failing test fixes needed.
...aredTest/java/org/oppia/android/app/onboarding/onboardingv2/NewLearnerProfileActivityTest.kt
Outdated
Show resolved
Hide resolved
...aredTest/java/org/oppia/android/app/onboarding/onboardingv2/NewLearnerProfileActivityTest.kt
Outdated
Show resolved
Hide resolved
...Test/java/org/oppia/android/app/onboarding/onboardingv2/OnboardingProfileTypeActivityTest.kt
Outdated
Show resolved
Hide resolved
...Test/java/org/oppia/android/app/onboarding/onboardingv2/OnboardingProfileTypeActivityTest.kt
Outdated
Show resolved
Hide resolved
...ava/org/oppia/android/app/onboarding/onboardingv2/OnboardingLearnerIntroFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
...Test/java/org/oppia/android/app/onboarding/onboardingv2/OnboardingProfileTypeFragmentTest.kt
Show resolved
Hide resolved
forceEnableOnboardingFlowV2() | ||
launchActivityWithLanguage(ENGLISH_AUDIO_LANGUAGE).use { | ||
testCoroutineDispatchers.runCurrent() | ||
onView(withId(R.id.audio_language_dropdown_background)).check( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to assert actual language. Ditto other tests
app/src/sharedTest/java/org/oppia/android/app/options/AudioLanguageFragmentTest.kt
Outdated
Show resolved
Hide resolved
onView(withId(R.id.onboarding_navigation_continue)) | ||
.perform(click()) | ||
testCoroutineDispatchers.runCurrent() | ||
intended(hasComponent(OnboardingLearnerIntroActivity::class.java.name)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for nichname in intent
intended(hasComponent(HomeActivity::class.java.name)) | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add checks for the rest of the views' visibility
…to new-onboarding-ui
Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Explanation
Fix Part of #4938: Intoduce the UI for the revised onboarding flow.
Essential Checklist
For UI-specific PRs only
Mobile
Tablet