Add PHP 8.2 to tests #130
Merged
Add PHP 8.2 to tests #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sorinsarca could you please approve the workflow? Curious to see |
|
+1 |
|
@sorinsarca Hey Sorin! Could you have a look at this PR? |
pascalheidmann
approved these changes
Jun 9, 2023
|
Given the release and addition of 8.3 (and the passage of time), we might want to add this in. Maybe, and this might be too spicy, we want to add in 8.4 too, but then make this passing either optional/ignore-able since there might be issues in the nightly which shouldn't block a release/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.2 is the current relevant version, let's make sure the library works there.