fix(MultipleOf): MultipleOf not working as expected #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sorinsarca will this be merged? If yes, when? Thx in advance :) |
|
better way to implement multipleof : |
MathieM
force-pushed
the
fix/MultipleOf/multipleOf-not-working-as-expected
branch
2 times, most recently
from
75b0d80
to
30e6c4f
Compare
MathieM
force-pushed
the
fix/MultipleOf/multipleOf-not-working-as-expected
branch
from
30e6c4f
to
f8d8f5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#123
Dealing with float is too complicated.
I add some test to help to understand but it's not working well for all cases.
You can find some examples here : https://3v4l.org/FpKHR