Merge pull request #21 from opf/fix/angular-standalone-components

fix: Custom icon viewboxes
opf · Jul 20, 2023 · 086ad93 · 086ad93
2 parents ebbb371 + b8455fe
commit 086ad93
Show file tree

Hide file tree

Showing 12 changed files with 14 additions and 11 deletions.
diff --git a/.changeset/fair-bugs-beam.md b/.changeset/fair-bugs-beam.md
@@ -0,0 +1,5 @@
+---
+'@openproject/octicons': patch
+---
+
+fix: Custom icon viewboxes
diff --git a/icons/op-export-pdf-1-24.svg b/icons/op-export-pdf-1-24.svg
diff --git a/icons/op-iconfont-scaler-24.svg b/icons/op-iconfont-scaler-24.svg
diff --git a/icons/op-remove-1-24.svg b/icons/op-remove-1-24.svg
diff --git a/icons/op-time-tracking-running-24.svg b/icons/op-time-tracking-running-24.svg
diff --git a/icons/op-time-tracking-start-24.svg b/icons/op-time-tracking-start-24.svg
diff --git a/icons/op-time-tracking-stop-24.svg b/icons/op-time-tracking-stop-24.svg
diff --git a/lib/octicons_angular/script/build.js b/lib/octicons_angular/script/build.js
@@ -47,7 +47,7 @@ const icons = Object.entries(octicons)
   template: \`
     <title *ngIf="title">{{title}}</title>
 
-    <path [outerHTML]="sanitizer.bypassSecurityTrustHtml(path)"></path>
+    <div [outerHTML]="sanitizer.bypassSecurityTrustHtml(path)"></div>
   \`,
 })
 export class Op${name} extends OpOcticonComponentBase {

diff --git a/lib/octicons_helper/Gemfile b/lib/octicons_helper/Gemfile
@@ -2,7 +2,7 @@ source "https://rubygems.org"
 
 gemspec
 
-gem "openproject-octicons", "19.4.0"
+gem "openproject-octicons", "19.5.7"
 gem "rails"
 
 group :development, :test do

diff --git a/lib/octicons_helper/octicons_helper.gemspec b/lib/octicons_helper/octicons_helper.gemspec
@@ -14,7 +14,7 @@ Gem::Specification.new do |s|
 
   s.require_paths = ["lib"]
 
-  s.add_dependency "openproject-octicons", "19.4.0"
+  s.add_dependency "openproject-octicons", "19.5.7"
   s.add_dependency "railties"
   s.add_dependency "actionview"
 end
diff --git a/lib/octicons_jekyll/Gemfile b/lib/octicons_jekyll/Gemfile
@@ -2,7 +2,7 @@ source "https://rubygems.org"
 
 gemspec
 
-gem "octicons", "19.5.7"
+gem "openproject-octicons", "19.5.7"
 
 group :development, :test do
   gem "minitest"

diff --git a/lib/octicons_jekyll/jekyll-octicons.gemspec b/lib/octicons_jekyll/jekyll-octicons.gemspec
@@ -14,5 +14,5 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   s.add_dependency "jekyll", ">= 3.6", "< 5.0"
-  s.add_dependency "octicons", "19.5.7"
+  s.add_dependency "openproject-octicons", "19.5.7"
 end