Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation fix #6492

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Documentation fix #6492

merged 3 commits into from
Jul 20, 2023

Conversation

PureRaidenCloud
Copy link
Contributor

Description of the change:

  • Delete _internal/google_news.html since its deprecated.
  • Update '.URL' to '.Permalink' since it can’t evaluate field URL in type *hugolib.pageState.
  • Update Go version from '1.18' tp '1.19' in building-operator section.

Checklist

  • I've built and serve your docs to localhost:1313.
  • Version of Go has successfully updated.

@PureRaidenCloud PureRaidenCloud temporarily deployed to deploy July 10, 2023 18:13 — with GitHub Actions Inactive
@PureRaidenCloud PureRaidenCloud temporarily deployed to deploy July 10, 2023 18:13 — with GitHub Actions Inactive
@PureRaidenCloud PureRaidenCloud temporarily deployed to deploy July 10, 2023 18:13 — with GitHub Actions Inactive
@PureRaidenCloud PureRaidenCloud temporarily deployed to deploy July 10, 2023 18:13 — with GitHub Actions Inactive
@PureRaidenCloud PureRaidenCloud temporarily deployed to deploy July 10, 2023 18:13 — with GitHub Actions Inactive
@PureRaidenCloud PureRaidenCloud temporarily deployed to deploy July 10, 2023 18:13 — with GitHub Actions Inactive
@PureRaidenCloud PureRaidenCloud temporarily deployed to deploy July 10, 2023 18:13 — with GitHub Actions Inactive
@everettraven
Copy link
Contributor

@PureRaidenCloud It looks like the sanity / sanity check is failing due to a tag issue. In order to fix this I believe you need to fetch the latest changes from master and perform a rebase.

everettraven
everettraven approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. In order for the changes to be reflected in the v1.30.x branch we will have to cherry pick this. After that I think a Netlify admin needs to kick off a rebuild for that subdomain

@rashmigottipati
Copy link
Member

@PureRaidenCloud can you please signoff the commit using git commit -s.

@PureRaidenCloud
Copy link
Contributor Author

@PureRaidenCloud can you please signoff the commit using git commit -s.

Hi @rashmigottipati, I've signed my commits.

everettraven
everettraven requested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PureRaidenCloud It looks like a rebase may have gone wrong. currently looks like there are changes that have already been merged and are more than just documentations.

Holding this PR until the issue is fixed:
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@rashmigottipati rashmigottipati mentioned this pull request Jul 20, 2023
Closed
@PureRaidenCloud
Fix a bug where google_news.html not found due to its deprecated.
ebc3375 
Signed-off-by: PureRaidenCloud <1017407329@qq.com>
@PureRaidenCloud
Change .URL to .Permalink
47cb760 
Signed-off-by: PureRaidenCloud <1017407329@qq.com>
@PureRaidenCloud
Fix operator-framework#6488
70c090a 
Signed-off-by: PureRaidenCloud <1017407329@qq.com>
@PureRaidenCloud
Copy link
Contributor Author

@PureRaidenCloud It looks like a rebase may have gone wrong. currently looks like there are changes that have already been merged and are more than just documentations.

Hi @everettraven , I've updated changes this MR, please review it again.

rashmigottipati
rashmigottipati approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2023
@rashmigottipati
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2023
@everettraven everettraven merged commit f3b3ecd into operator-framework:master Jul 20, 2023
24 checks passed
@everettraven
Copy link
Contributor

/cherrypick v1.30.x

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 20, 2023
Merged
@openshift-cherrypick-robot
Copy link

@everettraven: new pull request created: #6503

In response to this:

/cherrypick v1.30.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@everettraven everettraven everettraven approved these changes

@jberkhahn jberkhahn Awaiting requested review from jberkhahn

@theishshah theishshah Awaiting requested review from theishshah

Assignees

@rashmigottipati rashmigottipati

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PureRaidenCloud @everettraven @rashmigottipati @openshift-cherrypick-robot