Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ansible operator #6483

Merged
merged 12 commits into from
Jul 10, 2023
Merged

update ansible operator #6483

merged 12 commits into from
Jul 10, 2023

Conversation

everettraven
Copy link
Contributor

@everettraven everettraven commented Jun 28, 2023 •
edited
Loading

Description of the change:

  • Updates ansible to 2.15.0
  • Limits dependencies we manage by only including in the Pipfile:
    • ansible-core
    • ansible-runner
    • ansible-runner-http
    • kubernetes
    • urllib3 (need to pin this to a version <2 due to some issues encountered when running the testdata/ansible/memcached-operator with these changes)
  • Updates Python version to 3.9 (minimum supported by Ansible 2.15)
  • Updates CI to use new Python versions
  • Updates Ansible Operator scaffolding to remove the community.kubernetes collection (archived and replaced by kubernetes.core)
  • Updates Ansible Operator scaffolding to use the operator_sdk.util collection v0.5.0
  • Removes the ansible-2.11-preview image
  • Updates documentation around ansible base images to mention that after v1.30.0 base images will be based on ansible 2.15
  • Updates Ansible Operator scaffolding to use work with a newer version of molecule (v5.1.0)
  • Updates the base.Dockerfile to use multi-stage builds where Rust is installed before installing necessary python packages so that any architecture that may be missing prebuilt wheels can have the wheels built during the image build process.

A sample base image with these changes can be found at quay.io/rh_ee_bpalmer/ansible-operator:dev

Motivation for the change:

  • prevent users from using out of date and no longer supported ansible, python packages, and ansible collections

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2023
@everettraven everettraven temporarily deployed to deploy June 28, 2023 21:00 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 28, 2023 21:00 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 29, 2023 19:03 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 29, 2023 19:03 — with GitHub Actions Inactive
@everettraven everettraven changed the title WIP: remove the 'openshift' python package WIP: update ansible operator Jun 29, 2023
@oceanc80 oceanc80 mentioned this pull request Jun 29, 2023
Merged
@everettraven everettraven temporarily deployed to deploy June 30, 2023 18:02 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 30, 2023 18:02 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 30, 2023 18:02 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 30, 2023 18:02 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 30, 2023 18:02 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy June 30, 2023 18:02 — with GitHub Actions Inactive
@everettraven
remove the 'openshift' python package
eec29fb 
and the community.kubernetes collection that requires it

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven
upgrade ansible->2.15, update managed dependencies
4e3c170 
to only be what is absolutely necessary to get the memcached testdata operator to run

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven
modify managed dependencies to get rid of CVEs
53101c4 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven
remove the 2.11 preview image
dc7b688 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven
update CI
7092a16 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven
revert 'dev' tag usage in ansible-operator image
aaa9b16 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven
make generate
3be3bba 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven temporarily deployed to deploy July 3, 2023 15:55 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 15:55 — with GitHub Actions Inactive
@everettraven
add multi-stage builds
b29f14e 
that installs rust and will build necessary wheels if no pre-built
wheels exist for a given architecture. This allows us to continue
building base images for linux/ppc64le and linux/s390x platforms.

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven temporarily deployed to deploy July 3, 2023 16:46 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 16:46 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 16:46 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 16:46 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 16:46 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 16:46 — with GitHub Actions Inactive
@everettraven
add changelog
5b7fa94 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven marked this pull request as ready for review July 3, 2023 17:35
@everettraven everettraven temporarily deployed to deploy July 3, 2023 17:35 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 17:35 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 17:35 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 17:35 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 17:35 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy July 3, 2023 17:35 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot requested review from asmacdo and oceanc80 July 3, 2023 17:35
@everettraven everettraven changed the title WIP: update ansible operator update ansible operator Jul 3, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2023
@everettraven everettraven mentioned this pull request Jul 3, 2023
Closed
@oceanc80
Copy link
Collaborator

oceanc80 commented Jul 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023
@everettraven everettraven merged commit 03136c0 into operator-framework:master Jul 10, 2023
27 checks passed
PureRaidenCloud pushed a commit to PureRaidenCloud/operator-sdk that referenced this pull request Jul 18, 2023
@everettraven @PureRaidenCloud
update ansible operator (operator-framework#6483)
b6cf17c 
* upgrade ansible->2.15, update managed dependencies
to only be what is absolutely necessary to get the memcached testdata operator to run
---------
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: PureRaidenCloud <1017407329@qq.com>
@everettraven everettraven mentioned this pull request Jul 21, 2023
Closed
@acornett21 acornett21 mentioned this pull request Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oceanc80 oceanc80 oceanc80 approved these changes

@asmacdo asmacdo Awaiting requested review from asmacdo

Assignees

@oceanc80 oceanc80

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@everettraven @oceanc80