docs: update helm docs for the new layout #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilamacedo86
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
helm-plugin-doc
branch
3 times, most recently
from
7bd4d1c
to
b458219
Compare
camilamacedo86
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
added
language/helm
camilamacedo86
requested review from
bharathi-tenneti,
jmccormick2001,
jmrodri,
varshaprasad96 and
joelanford
This was referenced Jul 3, 2020
openshift-ci-robot
added
the
do-not-merge/hold
camilamacedo86
added
blocked
and removed
do-not-merge/hold
camilamacedo86
added a commit
to camilamacedo86/operator-sdk
that referenced
this pull request
Jul 8, 2020
…t public to users Removed the header for we are able to merge this doc without making it public to users and then, make it visible in the PR operator-framework#3326
camilamacedo86
added a commit
that referenced
this pull request
Jul 8, 2020
…#3342) **Description of the change:** - Add doc with the steps required that need is followed by the users migrate their project for the new layout. IMPORTANT: It is not visible on the website. The follow-up PR #3326 will make it visible. **Motivation for the change:** SDK is in a process to be integrated with KB which means that its project layouts will be aligned. More info : [Integrating Kubebuilder and Operator SDK](https://github.com/kubernetes-sigs/kubebuilder/blob/master/designs/integrating-kubebuilder-and-osdk.md). As part of this process, we are creating the Helm plugin. See PR #3295. Also, we are updating the steps in the doc in the PR #3326 and here we are adding a new doc which will help users to migrate their projects.
camilamacedo86
force-pushed
the
helm-plugin-doc
branch
2 times, most recently
from
a93d1f0
to
b563841
Compare
|
Hi @joelanford, All suggestions are applied. To make it easier has just 5 comments that I think you need to re-check and let us know if are they ok for you. They are: #3326 (comment), #3326 (comment), #3326 (comment), #3326 (comment), #3326 (comment). |
joelanford
reviewed
Jul 16, 2020
camilamacedo86
force-pushed
the
helm-plugin-doc
branch
4 times, most recently
from
c1738f7
to
f0854bb
Compare
camilamacedo86
commented
Jul 16, 2020
camilamacedo86
commented
Jul 16, 2020
camilamacedo86
force-pushed
the
helm-plugin-doc
branch
from
cfb2f2f
to
fafb894
Compare
|
Applied all suggestions + I re-due a re-check as well. I think it is good now. |
|
/lgtm |
joelanford
approved these changes
Jul 17, 2020
camilamacedo86
force-pushed
the
helm-plugin-doc
branch
from
fafb894
to
462d674
Compare
|
New changes are detected. LGTM label has been removed. |
added 2 commits
July 18, 2020 00:59
camilamacedo86
added a commit
to camilamacedo86/operator-sdk
that referenced
this pull request
Jul 19, 2020
**Description of the change:** Provide the same documentation and steps using the helm plugin. See the PR operator-framework#3421 which adds the plugin. - Update all related info in the Helm documentation - Create a new sub-directory called Legacy to keep the previous docs **Motivation** SDK is in a process to be integrated with KB which means that its project layouts will be aligned. More info : [Integrating Kubebuilder and Operator SDK](https://github.com/kubernetes-sigs/kubebuilder/blob/master/designs/integrating-kubebuilder-and-osdk.md) and [Extensible CLI and Scaffolding Plugins](https://github.com/kubernetes-sigs/kubebuilder/blob/master/designs/extensible-cli-and-scaffolding-plugins-phase-1.md).
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Provide the same documentation and steps using the helm plugin. See the PR #3421 which adds the plugin.
Motivation
SDK is in a process to be integrated with KB which means that its project layouts will be aligned. More info : Integrating Kubebuilder and Operator SDK and Extensible CLI and Scaffolding Plugins.