Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insecure option for Crane imageresolver #36

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Aug 7, 2023

The intent is to use this with operator-sdk to support a potential command like:

operator-sdk generate bundle --use-image-digests --insecure

This would allow us to build bundles (with digests) in environments without secure registries.

The intent is to use this with operator-sdk to support
a potential command like:

operator-sdk generate bundle --use-image-digests --insecure

This would allow us to build bundles (with digests) in
environments without secure registries.
Copy link

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023

@bcrochet: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zach-source
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@zach-source zach-source merged commit dbe96d8 into operator-framework:main Aug 8, 2023
1 check passed
@zach-source
Copy link
Collaborator

@dprince Thanks for the contribution!

@dprince
Copy link
Contributor Author

dprince commented Aug 8, 2023

Thanks all. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants