Skip to content
This repository has been archived by the owner on Sep 29, 2021. It is now read-only.

support thoth production deployment #20

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Conversation

harshad16
Copy link
Member

Related-To: thoth-station/thoth-application#709
Depends-On: thoth-station/thoth-application#712

support thoth production deployment
Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

@sesheta sesheta added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 8, 2020
@HumairAK
Copy link
Member

HumairAK commented Dec 8, 2020

/hold

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2020
@4n4nd
Copy link

4n4nd commented Dec 8, 2020

@harshad16 @HumairAK would it make sense to separate these components by namespace?
i.e. keep an individual kustomization.yaml for each namespace?

@harshad16
Copy link
Member Author

would it make sense to separate these components by namespace?
i.e. keep an individual kustomization.yaml for each namespace?

As its all thoth component, it is moved to thoth directory.
creating more sub-directory just feels more manual work, would it provide any additional value?

@4n4nd
Copy link

4n4nd commented Dec 8, 2020

would it provide any additional value?

would just make it look cleaner

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@harshad16
Copy link
Member Author

would just make it look cleaner

If it is not a requirement from the operate-first side then I would like to keep it this way, as it becomes easier for me(as a users) to check on what's missing.
if I move apps into more sub-directory, then the places to verify would grow with more number of Kustomization.yaml
checking everywhere if the resources are set or not.

@HumairAK
Copy link
Member

HumairAK commented Dec 8, 2020

it's not a requirement, organization of your team's sub folder is up to the team

@HumairAK
Copy link
Member

HumairAK commented Dec 8, 2020

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2020
@sesheta
Copy link
Member

sesheta commented Dec 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020
@sesheta sesheta merged commit 1cbd649 into operate-first:main Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants