Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lens UI not showing service names after latest redesign #2891

Closed
drolando opened this issue Oct 29, 2019 · 4 comments · Fixed by #2900
Closed

Lens UI not showing service names after latest redesign #2891

drolando opened this issue Oct 29, 2019 · 4 comments · Fixed by #2900
Labels
bug ui Zipkin UI

Comments

@drolando
Copy link
Contributor

After #2736 the lens UI doesn't show the service name for any of our traces. To reproduce, run lens locally and load zipkin-lens/testdata/yelp.json.

cc @tacigar
@tacigar
Copy link
Member

tacigar commented Oct 29, 2019

Thank you for sharing trace data!
I'll investigate the causes.

@tacigar tacigar added bug ui Zipkin UI labels Oct 29, 2019
@codefromthecrypt
Copy link
Member

search screen from latest:

Screenshot 2019-10-31 at 8 35 10 AM

trace detail from latest:

Screenshot 2019-10-31 at 8 36 04 AM

dependencies from latest:

Screenshot 2019-10-31 at 8 36 59 AM

@codefromthecrypt
Copy link
Member

the root span is incorrect as it has the shared flag set, but there's no corresponding client for it. I suspect that's an instrumentation bug an earlier version worked around. When you delete the shared flag, it looks fine.

I would have guessed span-cleaner would have cleaned this..

Screenshot 2019-10-31 at 8 43 33 AM
Screenshot 2019-10-31 at 8 44 41 AM

codefromthecrypt pushed a commit that referenced this issue Oct 31, 2019
Works around accidental shared flag on root spans
f55bbd7 
Fixes #2891
@codefromthecrypt codefromthecrypt mentioned this issue Oct 31, 2019
Merged
@codefromthecrypt
Copy link
Member

#2900

codefromthecrypt pushed a commit that referenced this issue Oct 31, 2019
@adriancole
Works around accidental shared flag on root spans (#2900)
f215024 
Fixes #2891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ui Zipkin UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Works around accidental shared flag on root spans openzipkin/zipkin
3 participants
@codefromthecrypt @drolando @tacigar