Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow switching between Zipkin Lens and prior UI during transition phase #2402

Closed
shakuzen opened this issue Feb 19, 2019 · 6 comments · Fixed by #2404
Closed

Allow switching between Zipkin Lens and prior UI during transition phase #2402

shakuzen opened this issue Feb 19, 2019 · 6 comments · Fixed by #2404
Labels

Comments

@shakuzen
Copy link
Member

Feature:
Allow Zipkin end-users to switch between Zipkin Lens and the historic UI.

Rational
We are transitioning between the two UIs and it would be a nicer user experience if individual users can switch between the two. Currently, only operators can decide which UI is used for all users of that deployment at startup. If users can switch, this gives them the choice of which UI to use when, and notably allows early adopters/testers of Zipkin Lens, while providing a fallback between when any issue is found and when a release is made with it fixed in Zipkin Lens.

Example Scenario
Power users want to try the latest and greatest UI for Zipkin without forcing all users to try it at once or all the time.

Prior Art
@adriancole may have found a way to hack this together ⛏️

codefromthecrypt pushed a commit that referenced this issue Feb 19, 2019
This adds a "Try Lens UI" button to the classic UI when running in the
standard build (which can server both asset trees at once). This is
controlled by `SUGGEST_LENS` env variable set to true by default. Those
simply hosting zipkin-ui assets will not be impacted.

This works via a normal browser cookie. If someone wants to stop using
lens, then close their browser and reload the page.

Fixes #2402
codefromthecrypt pushed a commit that referenced this issue Feb 20, 2019
This adds a "Try Lens UI" button to the classic UI when running in the
standard build (which can server both asset trees at once). This is
controlled by `SUGGEST_LENS` env variable set to true by default. Those
simply hosting zipkin-ui assets will not be impacted.

This works via a normal browser cookie. If someone wants to stop using
lens, then close their browser and reload the page.

Fixes #2402
abesto pushed a commit to abesto/zipkin that referenced this issue Sep 10, 2019
…n#2404)

This adds a "Try Lens UI" button to the classic UI when running in the
standard build (which can server both asset trees at once). This is
controlled by `SUGGEST_LENS` env variable set to true by default. Those
simply hosting zipkin-ui assets will not be impacted.

This works via a normal browser cookie. If someone wants to stop using
lens, then close their browser and reload the page.

Fixes openzipkin#2402
@dnozay
Copy link

dnozay commented Oct 18, 2019

hmmmm, how do I go back to the prior UI after trying lens?

@dnozay
Copy link

dnozay commented Oct 18, 2019

looks like removing cookie works.

@codefromthecrypt
Copy link
Member

re-opening as we lost the button to revert back to classic at some point. however, since #2736 changes a lot of things we can wait until that's merged to add it again.

@jy1989
Copy link

jy1989 commented Feb 14, 2020

still lost the button to revert back to classical ui with the latest version build from docker

@anuraaga
Copy link
Contributor

@jy1989 Thanks for noticing. To reduce maintenance cost and focus on improvement going forward, we've gone ahead and removed the classic UI from zipkin. We will have more detailed notes when doing the official release. You can see discussion here

#2971

We understand there are still some remaining issues but as a group of volunteers need to do this to best manage our resources. If any of the issues mentioned on that PR are important to you, would you be able to help with them? Or at least vote on what's most important to you if lens is still lacking functionality you need?

@jorgheymans
Copy link
Contributor

The transition phase is over, Lens is now the default UI. The previous 'classic' UI is no longer packaged with the server, no more button to revert back to the old UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants