Fixed the httpclient5 licenses. #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original PR that introduced these classes came from 2020, but the squash merge updated their git datetime to 2023, which makes the license formatting check fail on main. With this change, the headers are now correctly formatted according to the new git datetime, and a master branch build should hopefully succeed.
|
Could you please check the failure? |
|
@jeqo could you please review this? |
|
Will do, thanks @JochemKuijpers for reporting and provide a fix! |
jeqo
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR (#1274) that introduced these classes originated from 2020, but the squash merge commit updated their git datetime to 2023, which makes the license formatting check fail on the master branch.
With this change, the headers are now correctly formatted according to the new commit's datetime, and a master branch build should hopefully succeed.
I'm making this PR because I'm waiting on the support for Apache HTTP 5.2+ to arrive, so I'm hoping with this contribution that a new release could happen soon.