-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openwrt] Convert into an OpenWRT package #6 #25
[openwrt] Convert into an OpenWRT package #6 #25
Conversation
Opened this WIP PR so that it becomes easy to stack all relevant conversation. |
@nemesisdesign finally I am able to create an image but when I try to install it I got this error:-
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devkapilbansal I see that you're putting effort, but the makefile looks kinda wrong which is normal if you start copying things without really understanding what you're doing, so my suggestion is to start creating a very simple package for OpenWRT with something trivial (eg: a script in /usr/sbin
which prints hello world, get it to work (eg: you can call it from openwrt and it prints hello world) and then gradually add things.
In this specific case, giving us that output will not help, always try to look if the program you're running has a verbose output and include the verbose output in your request for help. Check with opkg --help
) and let me know what you can find.
a9ee23b
to
a1eae28
Compare
a1eae28
to
a406eb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is on the right track, please read again the deliverable:
Convert lua-monitoring into two OpenWRT packages:
One package for the netjson-monitoring utility, which aims to simply return NetJSON DeviceMonitoring output
One package which provides the OpenWISP Monitoring deamon, which depends on netjson-monitoring and openwisp-config (it takes the server information from the openwisp config file).
We need two packages, one of them is a daemon (crontab was a quick way to implement it).
Also remove netjson-monitoring-wan.lua
please.
openwisp-openwrt-monitoring/files/sbin/update-openwisp-packages
Outdated
Show resolved
Hide resolved
README.rst
Outdated
@@ -0,0 +1 @@ | |||
WIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please start preparing a basic README
63b7dfd
to
397ced7
Compare
397ced7
to
ec1b77f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please show the content of your feeds and commands to compile?
Ensure the feeds are correct and that this branch is being installed when you run ./scripts/feeds install -a && ./scripts/feeds update -a
, you should see this repo and this branch being cloned and installed on the openwrt source directory (you will find it in ./feeds
, if it's not there, something is wrong with the feeds).
Once you're sure the feeds are pulled correctly, ensure your .config
contains:
CONFIG_PACKAGE_openwisp-monitoring=y
CONFIG_PACKAGE_netjson-monitoring=y
Although you should be able to see these packages from make menuconfig
.
Then compile everything with make -j <number-of-cores> V=s
where j <number-of-cores>
stands for the number of cores your machine has available.
See also my comments below.
I am not able to reproduce the error that I was encountoring yesterday and package too compiled successfully. |
aa32816
to
8829e13
Compare
8829e13
to
e5cc9e2
Compare
@nemesisdesign does #9 makes sense now? I think they are merged already |
You can also do |
Hi, the problem was solved already but thanks for this. I will remember this for future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress @devkapilbansal, see my comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure of the following:
- the packages compile
- packages can be installed on a virgin OpenWRT installation and when this is done it pulls openwisp-config as a dependency (and its dependencies)
- ensure it can successfully post data to OpenWISP monitoring
Then we have to double check this, once those are checked we can merge this and go ahead with the other work.
Hi, I tried it on fresh OpenWRT but as I tested and all 5 packages compile ( 1 netjson-monitoring and 4 variants of openwisp-monitoring). The data was sent successfully to the server and error was logged when there was no connection to server. P.S.:- I use Update:- There was a minor error that I fixed in f7d3ad2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress, please specify in the README that the openwisp-monitoring openwrt package depends on openwisp-config (please also link "openwisp-config" to the URL of the repo) and that installing it will automatically install also openwisp-config and its dependencies.
2ce6a3e
to
89b57bf
Compare
16812ca
to
2e2e0ee
Compare
2e2e0ee
to
33a899c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move on so you can test this with github actions CI.
Closes #6
runbuild
script to automatically compile packages