[WIP][backend] Added support for plugins. #120
Conversation
There was a problem hiding this comment.
Great progress @R9295!
Let's start documenting this feature, I think we should do two things:
- dedicate a page to it
- mention it from basics and openwrt (which are the two most read pages), to increase chances users will see this
I can help you with these activities if you lay down the foundation for this.
| def add_plugins(cls, plugins): | ||
| for plugin in plugins: | ||
| plugin.schema.pop('$schema', None) | ||
| if getattr(cls, 'schema'): |
There was a problem hiding this comment.
as I was saying, we expect backend to always have a schema, therefore if schema is not present we should "fail early and loud"
| if getattr(cls, 'schema'): | ||
| cls.schema['properties'][plugin.key] = plugin.schema | ||
| if getattr(cls, 'converters'): | ||
| cls.converters.append(plugin.converter) |
There was a problem hiding this comment.
I think it's the same here, what's the use case of not having any converter declared? Wouldn't it just be wrong?
| 'uamsecret': 'asd123fghj' | ||
| }, | ||
| } | ||
| OpenWrt.add_plugins([CoovaPlugin()]) |
There was a problem hiding this comment.
keep in mind that once you do this, the plugin will be enabled during all the tests that are called afterwards (even other test classes), this may have unintended consequences in the future, I think you should do two things:
- subclass the
OpenWrtbackend here in this file, redefine theschemaandconvertersattributes to explicitly use a copy (usedeepcopy) ofOpenWrt.schemaandOpenWrt.converters, then use the subclass here in the tests - add a
tearDownmethod which cleans up any additional plugin every time a test method terminates execution
There was a problem hiding this comment.
@R9295 PS: please when you can, would be great if you could rebase on the current master and fix the flake8 warnings (I fixed the previous problem)
nemesifier
added this to In progress
in OpenWISP Priorities for next releases
via automation
nemesifier
moved this from In progress
to Needs review
in OpenWISP Priorities for next releases
No description provided.