Skip to content

Commit

Permalink
[openwrt] Remove config_name handling in firewall
Browse files Browse the repository at this point in the history
This removes the remnants of an attempt to manage older firewall
configurations from before the firewall schema was introduced.
However, this handling was incomplete and flawed, and so this code
is pointless.
  • Loading branch information
jonathanunderwood committed Mar 20, 2021
1 parent 3b51afe commit 8c6ac92
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions netjsonconfig/backends/openwrt/converters/firewall.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,6 @@ def __intermediate_rules(self, rules):
"""
result = []
for rule in rules:
if "config_name" in rule:
del rule["config_name"]
resultdict = OrderedDict(
((".name", self._get_uci_name(rule["name"])), (".type", "rule"))
)
Expand All @@ -107,8 +105,6 @@ def __intermediate_redirects(self, redirects):
"""
result = []
for redirect in redirects:
if "config_name" in redirect:
del redirect["config_name"]
resultdict = OrderedDict(
(
(".name", self._get_uci_name(redirect["name"])),
Expand Down Expand Up @@ -137,8 +133,6 @@ def __intermediate_includes(self, includes):
"""
result = []
for include in includes:
if "config_name" in include:
del include["config_name"]
resultdict = OrderedDict(
((".name", self._get_uci_name(include["name"])), (".type", "include"),)
)
Expand Down

0 comments on commit 8c6ac92

Please sign in to comment.