Parse default args configuration #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The implemented default map can be generated
sjovdnbos
reviewed
May 29, 2018
| from ovs.extensions.healthcheck.logger import Logger | ||
| from ovs.extensions.generic.configuration import Configuration |
sjovdnbos
requested changes
May 29, 2018
| @@ -536,11 +569,16 @@ def get_command(self, ctx, name): | |||
| :return: Function pointer to the command or None when no import could happen | |||
| :rtype: callable | |||
| """ | |||
| cmd = self.commands.get(name) | |||
There was a problem hiding this comment.
cmd = self.commands.get(name)
if cmd: return cmd
returns quite a couple of times.
Have you thought about ofloading it to a seperate function?
There was a problem hiding this comment.
Offloading won't really benefit it here
def get_possible_cached_command():
return self.commands.get(name)
cmd = self.get_possible_cached_command()
if cmd:
....
sjovdnbos
approved these changes
May 29, 2018
JeffreyDevloo
added a commit
that referenced
this pull request
May 29, 2018
…ation Parse default args configuration (cherry picked from commit dbba883)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.