Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANOMALY TASKS] Fix IndexError in adaptive threshold computation #967

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

djdameln
Copy link
Contributor

This PR fixes an issue that was sometimes encountered in anomaly tasks, where the adaptive threshold computation would raise an IndexError. A fix was recently merged in anomalib. This PR upgrades the anomaly tasks to the latest anomalib version so that the fix will be included in the OTE tasks.

For more details about the bugfix, see the description in the anomalib PR.

BMM

@djdameln djdameln requested review from samet-akcay and a team March 14, 2022 16:18
@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM ALGO Any changes in OTX Algo Tasks implementation labels Mar 14, 2022
@djdameln
Copy link
Contributor Author

run ote_sdk tests

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ovms-jenkins
Copy link

Can one of the admins verify this patch?

@Ilya-Krylov Ilya-Krylov merged commit 72ec1d5 into develop Mar 15, 2022
@Ilya-Krylov Ilya-Krylov deleted the da/anomaly-index-error branch March 15, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants