Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformation from StridedSlice to SpaceToDepth in yolov5 #7525

Closed
wants to merge 4 commits into from

Conversation

usstq
Copy link
Contributor

@usstq usstq commented Sep 16, 2021

Details:

  • Add stridedslice chain concat pattern matcher to fuse into spacetodepth
  • Add test cases

Tickets:

Signed-off-by: Li, Tingqian <tingqian.li@intel.com>
@usstq usstq requested review from a team September 16, 2021 03:31
@usstq usstq changed the title Tq/space to depth fusion Transformation from StridedSlice to SpaceToDepth in yolov5 Sep 16, 2021
@openvino-pushbot openvino-pushbot added category: inference OpenVINO Runtime library - Inference category: IE Tests OpenVINO Test: plugins and common category: Core OpenVINO Core (aka ngraph) labels Sep 16, 2021
Transform StridedSlice_chain+concat in yolov5 into SpaceToDepth

Signed-off-by: Li, Tingqian <tingqian.li@intel.com>
@usstq
Copy link
Contributor Author

usstq commented Sep 17, 2021

@GlebKazantaev Hi, Can you help to review this commit, Thanks!

@andrei-kochin
Copy link
Contributor

@ilyachur @GlebKazantaev could you please review this change?

@usstq usstq requested a review from a team December 20, 2021 05:11
@usstq
Copy link
Contributor Author

usstq commented Dec 20, 2021

@GlebKazantaev Hi Gleb, I've rebased my PR, could you please take a look? thanks!

@usstq
Copy link
Contributor Author

usstq commented Dec 22, 2021

@GlebKazantaev @dmitry-gorokhov Seems that yolov5 has introduced a better way to express this structure (even w/o using SpaceToDepth)

ultralytics/yolov5#4825

The most recent yolov5 network release already integrated this change, so this transformation is no longer useful for yolov5, should we abandon?

@usstq usstq closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants