Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPUW: Various fixes for FUNCALL_FOR_ALL #26937

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dmatveev
Copy link
Contributor

@dmatveev dmatveev commented Oct 7, 2024

Details:

  • Fix combination FUNCALL_FOR_ALL=YES + PIPELINE=NONE
  • Fix combination FUNCALL_FOR_ALL=YES + DCOFF - DQ
  • Performance: exclude FUNCALL_FOR_ALL-ed subgraphs from FUNCALL_ASYNC (ate resources for nothing)

There's one more change but I'd wait for banks to be merged first.

Tickets:

  • ticket-id

- In this case, function pipelining is enabled but there's no
  "next" rq to prepare

- Generally, exclude FCEW subgraphs from function pipelining
DCOFF rearranges closures what breaks.. Host Gather, which
is only activated with FUNCALL_FOR_ALL
@dmatveev dmatveev added this to the 2024.5 milestone Oct 7, 2024
@dmatveev dmatveev self-assigned this Oct 7, 2024
@dmatveev dmatveev requested review from a team as code owners October 7, 2024 14:35
@github-actions github-actions bot added category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin labels Oct 7, 2024
@dmatveev dmatveev added this pull request to the merge queue Oct 7, 2024
@dmatveev
Copy link
Contributor Author

dmatveev commented Oct 7, 2024

Thanks @smirnov-alexey for quick review!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2024
@dmatveev dmatveev added this pull request to the merge queue Oct 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants