Fix VOC to have task-specific formats #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #997 +/- ##
===========================================
- Coverage 78.53% 78.52% -0.01%
===========================================
Files 233 233
Lines 26749 26757 +8
Branches 5320 5323 +3
===========================================
+ Hits 21007 21012 +5
+ Misses 4497 4496 -1
- Partials 1245 1249 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
vinnamkim
reviewed
May 15, 2023
| anns = self._parse_annotations(root_elem, item_id=(item_id, self._subset)) | ||
| anns += self._parse_annotations(root_elem, item_id=(item_id, self._subset)) | ||
|
|
||
| if self._task in [VocTask.voc, VocTask.segmentation, VocTask.instance_segmentation]: |
There was a problem hiding this comment.
We can store the result of if self._task in [VocTask.voc, VocTask.segmentation, VocTask.instance_segmentation] outside of the loop.
Comment on lines
344
to
356
| if self._task & {VocTask.person_layout}: | ||
| for part_bbox in layout_bboxes: | ||
| if part_bbox.group != obj.group: | ||
| continue | ||
|
|
||
| part_elem = ET.SubElement(obj_elem, "part") | ||
| ET.SubElement(part_elem, "name").text = self.get_label(part_bbox.label) | ||
| _write_xml_bbox(part_bbox.get_bbox(), part_elem) |
There was a problem hiding this comment.
Suggested change
| if self._task & {VocTask.person_layout}: | |
| for part_bbox in layout_bboxes: | |
| if part_bbox.group != obj.group: | |
| continue | |
| part_elem = ET.SubElement(obj_elem, "part") | |
| ET.SubElement(part_elem, "name").text = self.get_label(part_bbox.label) | |
| _write_xml_bbox(part_bbox.get_bbox(), part_elem) | |
| no_person_layout_task = False if self._task & {VocTask.person_layout} else True | |
| ... | |
| if no_person_layout_task: | |
| continue | |
| for part_bbox in filter( | |
| lambda x: obj.group and obj.group == x.group, layout_bboxes | |
| ): | |
| part_elem = ET.SubElement(obj_elem, "part") | |
| ET.SubElement(part_elem, "name").text = self.get_label(part_bbox.label) | |
| _write_xml_bbox(part_bbox.get_bbox(), part_elem) |
cih9088
reviewed
May 16, 2023
added 20 commits
May 17, 2023 13:34
cih9088
approved these changes
May 17, 2023
vinnamkim
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.