Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CocoRoboflowImporter #976

Merged

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Apr 24, 2023

Summary

How to test

I added tests for this change.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added this to the 1.3.0 milestone Apr 24, 2023
@vinnamkim vinnamkim added data formats PR is related to dataset formats FEATURE New feature & functionality labels Apr 24, 2023
@vinnamkim vinnamkim marked this pull request as ready for review April 24, 2023 09:58
@vinnamkim vinnamkim requested review from a team as code owners April 24, 2023 09:58
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Patch coverage: 96.36% and project coverage change: +0.01 🎉

Comparison is base (769c620) 78.70% compared to head (380dcad) 78.72%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #976      +/-   ##
===========================================
+ Coverage    78.70%   78.72%   +0.01%     
===========================================
  Files          231      231              
  Lines        26420    26463      +43     
  Branches      5258     5263       +5     
===========================================
+ Hits         20795    20834      +39     
- Misses        4400     4402       +2     
- Partials      1225     1227       +2     
Flag Coverage Δ
macos-11_Python-3.8 77.76% <96.36%> (+0.03%) ⬆️
ubuntu-20.04_Python-3.8 78.72% <96.36%> (+0.03%) ⬆️
windows-2019_Python-3.8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/coco/base.py 92.30% <93.33%> (+0.21%) ⬆️
datumaro/plugins/data_formats/coco/format.py 100.00% <100.00%> (ø)
datumaro/plugins/data_formats/coco/importer.py 95.37% <100.00%> (+1.05%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim merged commit d202060 into openvinotoolkit:develop Apr 26, 2023
@vinnamkim vinnamkim deleted the feature/add-coco-roboflow-importer branch April 26, 2023 03:27
@vinnamkim vinnamkim mentioned this pull request May 17, 2023
6 tasks
vinnamkim added a commit that referenced this pull request May 17, 2023
- Add documentation part of #976 

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data formats PR is related to dataset formats FEATURE New feature & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants