-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs context-free commands subsection #969
Fix docs context-free commands subsection #969
Conversation
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that it is good idea to change .py
when the release is super close. It would be good to leave documentation changes here and the other things should be targeted to develop
.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## releases/1.2.0 #969 +/- ##
==================================================
- Coverage 78.71% 78.69% -0.03%
==================================================
Files 231 231
Lines 26420 26420
Branches 5258 5258
==================================================
- Hits 20796 20790 -6
- Misses 4400 4402 +2
- Partials 1224 1228 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@@ -9,7 +9,7 @@ The detection result may be one of: | |||
|
|||
- a single format being detected; | |||
- no formats being detected (if the dataset doesn't match any known format); | |||
- multiple formats being detected (if the dataset is ambiguous). | |||
- multiple formats being detected (if the dataset is ambiguous); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
seems correct, is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Fixed in bcc7a4d
(`?` is used for optional parts) | ||
|
||
```console | ||
datum merge <path/to/project1/> <path/to/project2/> <path/to/project3/> <path/toproject4/> \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
datum merge <path/to/project1/> <path/to/project2/> <path/to/project3/> <path/toproject4/> \ | |
datum merge <path/to/project1/> <path/to/project2/> <path/to/project3/> <path/to/project4/> \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in bcc7a4d
Co-authored-by: Vinnam Kim <vinnam.kim@gmail.com>
Co-authored-by: Vinnam Kim <vinnam.kim@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Summary
console
formatHow to test
Checklist
License
Feel free to contact the maintainers if that's a concern.