Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quick start guide #963

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

vinnamkim
Copy link
Contributor

Summary

  • Fix quick start guide according to the recent changes.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review April 20, 2023 04:55
@vinnamkim vinnamkim requested review from a team as code owners April 20, 2023 04:55
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Contributor

@cih9088 cih9088 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a quick start guide, users might just copy and paste the commands without knowing about messing up current directory by datum project create. How about adding creating project directory?

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5095007) 78.70% compared to head (a337388) 78.70%.

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.2.0     #963   +/-   ##
===============================================
  Coverage           78.70%   78.70%           
===============================================
  Files                 231      231           
  Lines               26420    26420           
  Branches             5258     5258           
===============================================
  Hits                20794    20794           
  Misses               4401     4401           
  Partials             1225     1225           
Flag Coverage Δ
macos-11_Python-3.8 77.72% <ø> (ø)
ubuntu-20.04_Python-3.8 78.68% <ø> (ø)
windows-2019_Python-3.8 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

vinnamkim and others added 3 commits April 20, 2023 14:37
Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com>
Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com>
Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com>
@vinnamkim vinnamkim merged commit 13fd698 into openvinotoolkit:releases/1.2.0 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants