Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align docs with the recent CLI changes #954

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Apr 19, 2023

Summary

  • Ticket no. 107276
  • Align docs with the recent CLI changes
    • Since we move some commands from the top-level to project context. I updated the existing docs for this change. For example,
      image

    • Split commands doctree into: 1) Context-free datum [command] and 2) Context datum <model|project|source|util> [command]
      Before
      image
      After
      image

    • Fix docs hyperlinks according to this change.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim changed the base branch from develop to releases/1.2.0 April 19, 2023 08:04
@vinnamkim vinnamkim marked this pull request as ready for review April 19, 2023 08:08
@vinnamkim vinnamkim requested review from a team as code owners April 19, 2023 08:08
@vinnamkim vinnamkim added the DOC Improvements or additions to documentation label Apr 19, 2023
@vinnamkim vinnamkim added this to the 1.2.0 milestone Apr 19, 2023
@vinnamkim vinnamkim requested a review from yunchu April 19, 2023 08:11
@@ -418,8 +418,7 @@ Single commands are handy shorter alternatives for the most used commands
and also special commands, which are hard to be put into any specific context.
`Docker <https://www.docker.com/>`_ is an example of similar approach.

.. raw:: html
:file: ../../../images/command_diag1.svg
.. graphviz:: command_line.dot
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yunchu
I updated GH actions to use graphviz in sphinx.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (e152dbd) 78.70% compared to head (a65d0ca) 78.69%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.2.0     #954      +/-   ##
==================================================
- Coverage           78.70%   78.69%   -0.02%     
==================================================
  Files                 231      231              
  Lines               26420    26420              
  Branches             5258     5258              
==================================================
- Hits                20794    20791       -3     
- Misses               4401     4402       +1     
- Partials             1225     1227       +2     
Flag Coverage Δ
macos-11_Python-3.8 77.73% <0.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.8 78.68% <0.00%> (ø)
windows-2019_Python-3.8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/cli/__main__.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim merged commit c533a10 into openvinotoolkit:releases/1.2.0 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants