Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic skills - Level 10: Data Generation #953

Merged

Conversation

bonhunko
Copy link
Contributor

@bonhunko bonhunko commented Apr 19, 2023

Summary

Ticket no. 107282
Add basic skills - Level 10: Data Generation

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bonhunko bonhunko requested review from a team as code owners April 19, 2023 03:30
@bonhunko bonhunko changed the title Add level-up documentation - level 10 data generation Add basic skills - Level 10: Data Generation Apr 19, 2023
@bonhunko bonhunko added the DOC Improvements or additions to documentation label Apr 19, 2023
@bonhunko bonhunko added this to the 1.2.0 milestone Apr 19, 2023
@bonhunko bonhunko force-pushed the doc/level_10_data_generation branch from 949abb8 to 98df627 Compare April 19, 2023 03:34
Training model with the synthetic dataset is one of famouse pre-training approach
since the manual annotations is quite expensive work.

Base on the `previous research <https://arxiv.org/abs/2103.13023>`_,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I modified to use citation.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run this CLI command in real to check whether it is working?

@bonhunko
Copy link
Contributor Author

bonhunko commented Apr 19, 2023

Did you run this CLI command in real to check whether it is working?

Yes, I manually checked both CLI & Python API

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ef6ab36) 78.70% compared to head (e88c23e) 78.70%.

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.2.0     #953   +/-   ##
===============================================
  Coverage           78.70%   78.70%           
===============================================
  Files                 232      232           
  Lines               26420    26420           
  Branches             5258     5258           
===============================================
  Hits                20795    20795           
  Misses               4400     4400           
  Partials             1225     1225           
Flag Coverage Δ
macos-11_Python-3.8 77.73% <ø> (-0.01%) ⬇️
ubuntu-20.04_Python-3.8 78.69% <ø> (ø)
windows-2019_Python-3.8 78.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bonhunko bonhunko force-pushed the doc/level_10_data_generation branch 2 times, most recently from c7c6b87 to e88c23e Compare April 19, 2023 04:03
@bonhunko bonhunko requested a review from vinnamkim April 19, 2023 04:05
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bonhunko bonhunko merged commit 6529b60 into openvinotoolkit:releases/1.2.0 Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants