Refactor Image/PointCloud 2 #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
cih9088
requested review from
vinnamkim,
chuneuny-emily,
sstrehlk and
sooahleex
vinnamkim
reviewed
Apr 17, 2023
| @@ -165,7 +165,7 @@ def _load_inference_from_subset(extractor, subset_name): | |||
| width, height = item.media.size | |||
| data_df["Width"].append(width) | |||
| data_df["Height"].append(height) | |||
| data_df["ImagePath"].append(item.media.path) | |||
| data_df["ImagePath"].append(getattr(item.media, "path", None)) | |||
There was a problem hiding this comment.
I guess we would rather add path property which returns None to the base media class.
There was a problem hiding this comment.
Yes, indeed. path is way more used than I thought across Datumaro. Lets make it happen in another PR.
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
cih9088
force-pushed
the
refactor/image2
branch
from
3e84aeb
to
c9ea1c3
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## releases/1.2.0 #944 +/- ##
===============================================
Coverage 78.68% 78.69%
===============================================
Files 231 231
Lines 26408 26417 +9
Branches 5257 5258 +1
===============================================
+ Hits 20780 20789 +9
+ Misses 4403 4401 -2
- Partials 1225 1227 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
wonjuleee
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A following work of #911, #921
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.