Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update merge tutorial for real life usecase #930

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Apr 12, 2023

Summary

  • Ticket no. 107273
  • Update merge tutorial (Jupyter notebook) for real life usecase

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@vinnamkim vinnamkim changed the base branch from develop to releases/1.2.0 April 14, 2023 10:16
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim force-pushed the docs/upgrade-merge-tutorial-for-real-life-usecase branch from fca3bf3 to bba866d Compare April 17, 2023 01:47
@vinnamkim vinnamkim added the DOC Improvements or additions to documentation label Apr 17, 2023
@vinnamkim vinnamkim added this to the 1.2.0 milestone Apr 17, 2023
@vinnamkim vinnamkim marked this pull request as ready for review April 17, 2023 01:48
@vinnamkim vinnamkim requested review from a team as code owners April 17, 2023 01:48
@vinnamkim
Copy link
Contributor Author

It's ready. Please review it.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (d82eaf5) 78.64% compared to head (bba866d) 78.71%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.2.0     #930      +/-   ##
==================================================
+ Coverage           78.64%   78.71%   +0.07%     
==================================================
  Files                 231      231              
  Lines               26453    26455       +2     
  Branches             5268     5269       +1     
==================================================
+ Hits                20804    20825      +21     
+ Misses               4422     4402      -20     
- Partials             1227     1228       +1     
Flag Coverage Δ
macos-11_Python-3.8 77.75% <ø> (+0.08%) ⬆️
ubuntu-20.04_Python-3.8 78.71% <ø> (+0.08%) ⬆️
windows-2019_Python-3.8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim changed the title Docs/upgrade merge tutorial for real life usecase Update merge tutorial for real life usecase Apr 17, 2023
@vinnamkim vinnamkim merged commit 57ccba7 into openvinotoolkit:releases/1.2.0 Apr 17, 2023
@vinnamkim vinnamkim deleted the docs/upgrade-merge-tutorial-for-real-life-usecase branch April 17, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants