Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not saving extra images of PointCloud in datumaro format #918

Merged
merged 3 commits into from
Apr 7, 2023

Conversation

cih9088
Copy link
Contributor

@cih9088 cih9088 commented Apr 6, 2023

Summary

The extra images were not saved during Datumaro format export.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
@cih9088 cih9088 added the BUG Something isn't working label Apr 6, 2023
@cih9088 cih9088 added this to the 1.2.0 milestone Apr 6, 2023
@cih9088 cih9088 requested review from a team as code owners April 6, 2023 05:51
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for it?

@vinnamkim
Copy link
Contributor

Can we have a test for it?

We could use this asset, https://github.com/openvinotoolkit/datumaro/tree/develop/tests/assets/sly_pointcloud_dataset

@cih9088
Copy link
Contributor Author

cih9088 commented Apr 6, 2023

Can we have a test for it?

If only this part is replaced with test.assertEqual(item_a.media, item_b.media) to compare contents.

As you commented in the code block, just replacing it causes lots of error. The Image refactoring branch I'm working on fixed it and hopefully it got merged soon.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ddde11d) 78.86% compared to head (c3dabc5) 78.86%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #918   +/-   ##
========================================
  Coverage    78.86%   78.86%           
========================================
  Files          215      215           
  Lines        25202    25204    +2     
  Branches      5043     5043           
========================================
+ Hits         19876    19878    +2     
  Misses        4191     4191           
  Partials      1135     1135           
Flag Coverage Δ
macos-11_Python-3.8 ?
ubuntu-20.04_Python-3.8 78.86% <100.00%> (+<0.01%) ⬆️
windows-2019_Python-3.8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/datumaro/exporter.py 94.95% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

vinnamkim
vinnamkim previously approved these changes Apr 6, 2023
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

sooahleex
sooahleex previously approved these changes Apr 7, 2023
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cih9088 cih9088 dismissed stale reviews from sooahleex and vinnamkim via c3dabc5 April 7, 2023 02:08
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cih9088 cih9088 merged commit d122ab8 into openvinotoolkit:develop Apr 7, 2023
@cih9088 cih9088 deleted the fix/not-saved-extra-images branch April 7, 2023 04:27
@cih9088
Copy link
Contributor Author

cih9088 commented Apr 7, 2023

Can we have a test for it?

If only this part is replaced with test.assertEqual(item_a.media, item_b.media) to compare contents.

As you commented in the code block, just replacing it causes lots of error. The Image refactoring branch I'm working on fixed it and hopefully it got merged soon.

Fixed in #921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants