-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not saving extra images of PointCloud in datumaro format #918
Fix not saving extra images of PointCloud in datumaro format #918
Conversation
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a test for it?
We could use this asset, https://github.com/openvinotoolkit/datumaro/tree/develop/tests/assets/sly_pointcloud_dataset |
If only this part is replaced with As you commented in the code block, just replacing it causes lots of error. The |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #918 +/- ##
========================================
Coverage 78.86% 78.86%
========================================
Files 215 215
Lines 25202 25204 +2
Branches 5043 5043
========================================
+ Hits 19876 19878 +2
Misses 4191 4191
Partials 1135 1135
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Fixed in #921 |
Summary
The extra images were not saved during Datumaro format export.
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.