-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to not export absolute media path in Datumaro and DatumaroBinary formats #896
Fix to not export absolute media path in Datumaro and DatumaroBinary formats #896
Conversation
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## releases/1.1.0 #896 +/- ##
==================================================
- Coverage 78.61% 78.60% -0.02%
==================================================
Files 205 205
Lines 25067 25078 +11
Branches 5029 5029
==================================================
+ Hits 19706 19712 +6
- Misses 4229 4233 +4
- Partials 1132 1133 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
How to test
This change will be covered by
move_save_dir=True
:datumaro/tests/utils/test_utils.py
Lines 304 to 307 in 7c6541a
Checklist
License
Feel free to contact the maintainers if that's a concern.