Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to not export absolute media path in Datumaro and DatumaroBinary formats #896

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Mar 27, 2023

Summary

  • Ticket no. 106811

How to test

This change will be covered by move_save_dir=True:

if move_save_dir:
save_dir = tmp_dir
for file in os.listdir(test_dir):
shutil.move(osp.join(test_dir, file), save_dir)

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim changed the title Fix not to export absolute media path Fix to not export absolute media path in Datumaro and DatumaroBinary formats Mar 27, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review March 27, 2023 08:02
@vinnamkim vinnamkim added this to the 1.1.0 milestone Mar 27, 2023
@vinnamkim vinnamkim added the BUG Something isn't working label Mar 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Patch coverage: 90.24% and project coverage change: -0.02 ⚠️

Comparison is base (b501015) 78.61% compared to head (7c6541a) 78.60%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.1.0     #896      +/-   ##
==================================================
- Coverage           78.61%   78.60%   -0.02%     
==================================================
  Files                 205      205              
  Lines               25067    25078      +11     
  Branches             5029     5029              
==================================================
+ Hits                19706    19712       +6     
- Misses               4229     4233       +4     
- Partials             1132     1133       +1     
Flag Coverage Δ
macos-11_Python-3.8 77.58% <90.24%> (-0.02%) ⬇️
ubuntu-20.04_Python-3.8 78.59% <90.24%> (-0.02%) ⬇️
windows-2019_Python-3.8 78.53% <90.24%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/datumaro/exporter.py 94.93% <81.81%> (-0.79%) ⬇️
...ugins/data_formats/datumaro_binary/mapper/media.py 88.37% <84.61%> (+0.13%) ⬆️
datumaro/components/exporter.py 84.07% <100.00%> (-0.77%) ⬇️
datumaro/plugins/data_formats/datumaro/base.py 93.66% <100.00%> (-1.38%) ⬇️
...umaro/plugins/data_formats/datumaro_binary/base.py 93.97% <100.00%> (+0.14%) ⬆️
...ata_formats/datumaro_binary/mapper/dataset_item.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnamkim vinnamkim merged commit ce23fca into openvinotoolkit:releases/1.1.0 Mar 27, 2023
@vinnamkim vinnamkim deleted the bugfix/dont-use-absolute-path-when-datumaro-export-1 branch March 27, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants