Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YOLO Loose format #856

Merged

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Mar 15, 2023

Summary

  • Ticket no. 104512
  • Currently, YOLO format requires too strict directory structure and too many meta files.
  • Add YoloLooseImporter and revisit notebooks/06_tiling.ipynb to use it.
  • Add documentation for YoloLoose format.

How to test

I added tests to cover this change and made some refactoring of the existing tests by moving some tests to tests/unit/data_formats/test_yolo_format.py.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
…lo-format

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added ENHANCE Enhancement of existing features data formats PR is related to dataset formats labels Mar 15, 2023
@vinnamkim vinnamkim marked this pull request as ready for review March 15, 2023 05:36
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Patch coverage: 84.75% and project coverage change: +0.01 🎉

Comparison is base (21755d3) 78.59% compared to head (4596f11) 78.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #856      +/-   ##
===========================================
+ Coverage    78.59%   78.60%   +0.01%     
===========================================
  Files          198      200       +2     
  Lines        24377    24497     +120     
  Branches      4932     4950      +18     
===========================================
+ Hits         19159    19257      +98     
- Misses        4118     4132      +14     
- Partials      1100     1108       +8     
Flag Coverage Δ
macos-11_Python-3.8 77.95% <84.75%> (+0.01%) ⬆️
ubuntu-20.04_Python-3.8 78.60% <84.75%> (+0.01%) ⬆️
windows-2019_Python-3.8 78.54% <84.75%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/format_detection.py 93.54% <ø> (ø)
datumaro/components/importer.py 89.68% <ø> (ø)
datumaro/plugins/data_formats/yolo/importer.py 81.39% <81.39%> (ø)
datumaro/plugins/data_formats/yolo/base.py 87.50% <84.74%> (-2.33%) ⬇️
datumaro/components/dataset_base.py 74.69% <100.00%> (ø)
datumaro/components/media.py 83.56% <100.00%> (ø)
datumaro/plugins/data_formats/yolo/format.py 100.00% <100.00%> (ø)
datumaro/util/definitions.py 100.00% <100.00%> (ø)
datumaro/util/os_util.py 66.66% <100.00%> (+1.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim mentioned this pull request Mar 16, 2023
7 tasks
@vinnamkim vinnamkim added this to the 1.1.0 milestone Mar 16, 2023
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late response, but it looks good to me! Please merge this.

@vinnamkim vinnamkim merged commit 36c2d4b into openvinotoolkit:develop Mar 17, 2023
@vinnamkim vinnamkim deleted the enhance/loose-yolo-format branch March 17, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data formats PR is related to dataset formats ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants