Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ultralytics YOLO format #859

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Mar 16, 2023

Summary

  • Ticket no. 104512
  • Add YoloUltralyticsImport and YoloUltralyticsExporter.
  • Add documentation for YoloUltralytics format.
  • Add E2E example from the dataset conversion to the model training using YoloV8-Ultralytics trainer, notebooks/08_e2e_example_yolo_ultralytics_trainer.ipynb.

How to test

Add a test to cover this change.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
…lo-format

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added ENHANCE Enhancement of existing features data formats PR is related to dataset formats labels Mar 16, 2023
@vinnamkim vinnamkim added this to the 1.1.0 milestone Mar 16, 2023
…rt-ultralytics-yolo-format

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review March 17, 2023 03:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Patch coverage: 80.59% and project coverage change: -0.04 ⚠️

Comparison is base (36c2d4b) 78.59% compared to head (51c8112) 78.55%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #859      +/-   ##
===========================================
- Coverage    78.59%   78.55%   -0.04%     
===========================================
  Files          201      201              
  Lines        24534    24640     +106     
  Branches      4957     4976      +19     
===========================================
+ Hits         19282    19356      +74     
- Misses        4141     4169      +28     
- Partials      1111     1115       +4     
Flag Coverage Δ
macos-11_Python-3.8 77.90% <80.59%> (-0.04%) ⬇️
ubuntu-20.04_Python-3.8 78.54% <80.59%> (-0.04%) ⬇️
windows-2019_Python-3.8 78.48% <80.59%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/yolo/exporter.py 71.64% <76.92%> (-8.00%) ⬇️
datumaro/plugins/data_formats/yolo/base.py 87.56% <89.47%> (+0.06%) ⬆️
datumaro/plugins/data_formats/yolo/format.py 100.00% <100.00%> (ø)
datumaro/plugins/data_formats/yolo/importer.py 84.61% <100.00%> (+3.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinnamkim vinnamkim merged commit 6a739e3 into openvinotoolkit:develop Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data formats PR is related to dataset formats ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants