Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommonSemanticSegmentationWithSubsetDirsImporter #826

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Feb 24, 2023

Summary

  • Ticket no. 104803
  • To simplify OTX CLI data argument, extend Datumaro CommonSemanticSegmentation format importer to cover the following subset structure.
    Dataset/
    └─ <split: train,val, ...>
        ├── dataset_meta.json # a list of labels
        ├── images/
        │   ├── <img1>.png
        │   ├── <img2>.png
        │   └── ...
        └── masks/
            ├── <img1>.png
            ├── <img2>.png
            └── ... 
Then, the imported dataset will have train, val, ... CommonSemanticSegmentation subsets.
  • CommonSemanticSegmentationWithSubsetDirsImporter will take this role.
  • Refactor and migrate CommonSemanticSegmentation unit tests to pytest.

How to test

Include unit tests to cover it's implementation.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
 - Refactor CommonSemanticSegmentation unit tests as well

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added this to the 1.1.0 milestone Feb 24, 2023
@vinnamkim vinnamkim added refactoring data formats PR is related to dataset formats TEST Any changes in tests labels Feb 24, 2023
@vinnamkim vinnamkim changed the title Feature/add common semantic seg with subset dirs Add CommonSemanticSegmentationWithSubsetDirsImporter Feb 24, 2023
@vinnamkim vinnamkim marked this pull request as ready for review February 27, 2023 05:08
…on-semantic-seg-with-subset-dirs

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Base: 78.33% // Head: 78.35% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (60565c7) compared to base (79b9eb1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #826      +/-   ##
===========================================
+ Coverage    78.33%   78.35%   +0.01%     
===========================================
  Files          189      189              
  Lines        23681    23697      +16     
  Branches      4895     4901       +6     
===========================================
+ Hits         18550    18567      +17     
  Misses        4032     4032              
+ Partials      1099     1098       -1     
Flag Coverage Δ
macos-11_Python-3.8 77.65% <100.00%> (+0.01%) ⬆️
ubuntu-20.04_Python-3.8 78.33% <100.00%> (+0.01%) ⬆️
windows-2019_Python-3.8 78.26% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/util/image.py 90.39% <ø> (ø)
datumaro/components/format_detection.py 92.98% <100.00%> (+0.34%) ⬆️
...ugins/data_formats/common_semantic_segmentation.py 82.02% <100.00%> (+0.62%) ⬆️
datumaro/plugins/data_formats/imagenet.py 90.14% <100.00%> (ø)
datumaro/util/os_util.py 64.70% <100.00%> (+1.34%) ⬆️
datumaro/plugins/splitter.py 88.66% <0.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim added this pull request to the merge queue Feb 28, 2023
Merged via the queue into openvinotoolkit:develop with commit 1e6761b Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data formats PR is related to dataset formats refactoring TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants