-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add with_subset_dirs decorator #816
Add with_subset_dirs decorator #816
Conversation
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportBase: 78.26% // Head: 78.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #816 +/- ##
========================================
Coverage 78.26% 78.26%
========================================
Files 184 184
Lines 23563 23614 +51
Branches 4880 4892 +12
========================================
+ Hits 18442 18482 +40
- Misses 4028 4033 +5
- Partials 1093 1099 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Please see #817 (comment), this PR should be blocked until the backport of v1.0.0. |
What a nice feature, it must improve the user experience. Thanks |
- Move from v1.0.0 to v1.1.0 Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Done. It's ready for review now. |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but could you provide some examples for using with_subset_dirs
more than ImageNet
cases?
It must be good! |
Summary
otx train [${template}] --train-data-roots ${root}/train --val-data-roots ${root}/val
which needs the directory path at the subset level but Multi-label Classification task requires only the root level directory path such asotx train [${template}] --train-data-roots ${root} --val-data-roots ${root}
. This should be resolved from Datumaro side.@with_subset_dirs
decorator to make the existing importer to handle the following directory structure including subsets:@with_subset_dirs
,ImagenetWithSubsetDirsImporter
will cover the Multi-class Classification task case.How to test
I added unit tests to cover this feature.
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.