-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix model remove CLI command #805
Fix model remove CLI command #805
Conversation
- Fix model loading in datum explain - Add an integration test for datum explain Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
- Fix datum model info description too Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportBase: 77.67% // Head: 77.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #805 +/- ##
===========================================
- Coverage 77.67% 77.67% -0.01%
===========================================
Files 179 179
Lines 23335 23337 +2
Branches 5032 5032
===========================================
Hits 18126 18126
- Misses 4146 4148 +2
Partials 1063 1063
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for your contribution.
This should be merged after #804.
Summary
datum model remove model-0
CLI command cannot remove "model-0" although it was enrolled in the project already.datum model info
description is also added.How to test
I added a test to cover this bug.
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.