-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix model loading in datum explain #804
Conversation
- Fix model loading in datum explain - Add an integration test for datum explain Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportBase: 83.93% // Head: 84.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #804 +/- ##
===========================================
+ Coverage 83.93% 84.42% +0.49%
===========================================
Files 174 174
Lines 22941 22943 +2
Branches 4973 4974 +1
===========================================
+ Hits 19255 19370 +115
+ Misses 2559 2424 -135
- Partials 1127 1149 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! I left a comment only for a typo thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Summary
datum explain
datum explain
How to test
This change will be covered in the added test.
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.