Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model loading in datum explain #804

Merged
merged 8 commits into from
Feb 9, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Feb 3, 2023

Summary

How to test

This change will be covered in the added test.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

 - Fix model loading in datum explain
 - Add an integration test for datum explain

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added BUG Something isn't working cli labels Feb 3, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Base: 83.93% // Head: 84.42% // Increases project coverage by +0.49% 🎉

Coverage data is based on head (b7d7c4f) compared to base (3aa4742).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #804      +/-   ##
===========================================
+ Coverage    83.93%   84.42%   +0.49%     
===========================================
  Files          174      174              
  Lines        22941    22943       +2     
  Branches      4973     4974       +1     
===========================================
+ Hits         19255    19370     +115     
+ Misses        2559     2424     -135     
- Partials      1127     1149      +22     
Flag Coverage Δ
macos-11_Python-3.10 83.94% <0.00%> (+0.10%) ⬆️
macos-11_Python-3.7 83.61% <0.00%> (+0.07%) ⬆️
macos-11_Python-3.8 83.87% <0.00%> (+0.09%) ⬆️
macos-11_Python-3.9 83.88% <0.00%> (+0.09%) ⬆️
ubuntu-20.04_Python-3.10 84.34% <33.33%> (+0.48%) ⬆️
ubuntu-20.04_Python-3.7 84.02% <33.33%> (+0.47%) ⬆️
ubuntu-20.04_Python-3.8 84.28% <33.33%> (+0.48%) ⬆️
ubuntu-20.04_Python-3.9 84.29% <33.33%> (+0.48%) ⬆️
windows-2019_Python-3.10 84.30% <33.33%> (+0.49%) ⬆️
windows-2019_Python-3.7 83.97% <33.33%> (+0.47%) ⬆️
windows-2019_Python-3.8 84.22% <33.33%> (+0.49%) ⬆️
windows-2019_Python-3.9 84.24% <33.33%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/cli/commands/explain.py 55.43% <33.33%> (+19.87%) ⬆️
datumaro/components/project.py 80.84% <0.00%> (+0.06%) ⬆️
datumaro/plugins/splitter.py 88.69% <0.00%> (+0.22%) ⬆️
datumaro/util/annotation_util.py 74.19% <0.00%> (+0.64%) ⬆️
datumaro/components/algorithms/rise.py 89.65% <0.00%> (+0.68%) ⬆️
datumaro/util/image.py 91.57% <0.00%> (+1.12%) ⬆️
datumaro/util/telemetry_utils.py 79.16% <0.00%> (+3.33%) ⬆️
datumaro/cli/contexts/model.py 65.41% <0.00%> (+12.78%) ⬆️
datumaro/plugins/openvino_plugin/launcher.py 60.48% <0.00%> (+55.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
bonhunko
bonhunko previously approved these changes Feb 6, 2023
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I left a comment only for a typo thing.

datumaro/cli/commands/explain.py Outdated Show resolved Hide resolved
sooahleex
sooahleex previously approved these changes Feb 6, 2023
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vinnamkim vinnamkim dismissed stale reviews from sooahleex and bonhunko via b7d7c4f February 6, 2023 01:52
@vinnamkim vinnamkim mentioned this pull request Feb 6, 2023
7 tasks
@vinnamkim vinnamkim merged commit 75de6df into openvinotoolkit:develop Feb 9, 2023
@vinnamkim vinnamkim added this to the 1.0.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explain command cannot find the model
4 participants