Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MacOS CI failures #789

Merged

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jan 6, 2023

Signed-off-by: Kim, Vinnam vinnam.kim@intel.com

Summary

How to test

  • See CI results

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Base: 83.84% // Head: 83.84% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (72fe90f) compared to base (99d0396).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #789   +/-   ##
========================================
  Coverage    83.84%   83.84%           
========================================
  Files          170      170           
  Lines        22558    22561    +3     
  Branches      4919     4920    +1     
========================================
+ Hits         18914    18917    +3     
  Misses        2526     2526           
  Partials      1118     1118           
Flag Coverage Δ
macos-11_Python-3.10 83.76% <66.66%> (?)
macos-11_Python-3.7 83.39% <66.66%> (?)
macos-11_Python-3.8 83.69% <66.66%> (?)
macos-11_Python-3.9 83.70% <66.66%> (?)
ubuntu-20.04_Python-3.10 83.75% <33.33%> (-0.01%) ⬇️
ubuntu-20.04_Python-3.7 83.39% <33.33%> (-0.06%) ⬇️
ubuntu-20.04_Python-3.8 83.69% <33.33%> (-0.01%) ⬇️
ubuntu-20.04_Python-3.9 83.69% <33.33%> (-0.01%) ⬇️
windows-2019_Python-3.10 83.72% <33.33%> (-0.02%) ⬇️
windows-2019_Python-3.7 83.36% <33.33%> (-0.06%) ⬇️
windows-2019_Python-3.8 83.64% <33.33%> (-0.01%) ⬇️
windows-2019_Python-3.9 83.66% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/synthetic_data/utils.py 85.00% <100.00%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim force-pushed the fix/upgrade-ci-mac-os-version branch from d0b4b89 to f570aea Compare January 6, 2023 03:58
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim force-pushed the fix/upgrade-ci-mac-os-version branch from f570aea to b7c318f Compare January 6, 2023 04:07
@vinnamkim vinnamkim changed the title Add C build extensions to .gitignore Fix MacOS CI failures Jan 6, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added BUG Something isn't working infra labels Jan 6, 2023
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinnamkim vinnamkim merged commit 4aa93bf into openvinotoolkit:develop Jan 6, 2023
zhiltsov-max added a commit to cvat-ai/datumaro that referenced this pull request Jan 26, 2023
zhiltsov-max added a commit to cvat-ai/datumaro that referenced this pull request Jan 27, 2023
* Fix installation problem

* Port fix for MacOS OpenCV bug from openvinotoolkit#789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants