Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an exception when exporting a dataset to VOC format with labels containing 'blank space' #771

Merged

Conversation

bonhunko
Copy link
Contributor

@bonhunko bonhunko commented Nov 29, 2022

Summary

Resolves CVS-97188
Exporting a dataset to VOC format including a label containing 'blank space' triggers an exception

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bonhunko bonhunko marked this pull request as ready for review November 29, 2022 02:26
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Base: 84.18% // Head: 84.17% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (def68cc) compared to base (b9db543).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #771      +/-   ##
===========================================
- Coverage    84.18%   84.17%   -0.01%     
===========================================
  Files          157      157              
  Lines        22063    22064       +1     
  Branches      4830     4830              
===========================================
  Hits         18573    18573              
  Misses        2389     2389              
- Partials      1101     1102       +1     
Flag Coverage Δ
macos-10.15_Python-3.10 84.09% <100.00%> (+<0.01%) ⬆️
macos-10.15_Python-3.7 83.77% <100.00%> (-0.01%) ⬇️
macos-10.15_Python-3.8 84.01% <100.00%> (+<0.01%) ⬆️
macos-10.15_Python-3.9 84.03% <100.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.10 84.10% <100.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.7 83.79% <100.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.8 84.03% <100.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.9 84.04% <100.00%> (-0.01%) ⬇️
windows-2019_Python-3.10 84.10% <100.00%> (+<0.01%) ⬆️
windows-2019_Python-3.7 83.79% <100.00%> (+<0.01%) ⬆️
windows-2019_Python-3.8 84.02% <100.00%> (+<0.01%) ⬆️
windows-2019_Python-3.9 84.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/voc_format/converter.py 90.05% <100.00%> (+0.01%) ⬆️
datumaro/plugins/splitter.py 88.44% <0.00%> (-0.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bonhunko bonhunko changed the title fix voc exporting with labels with space Fix an exception when exporting a dataset to VOC format with labels containing 'blank space' Nov 29, 2022
@bonhunko bonhunko force-pushed the cvs-97188_fix_voc_export branch 2 times, most recently from fb38dc6 to def68cc Compare November 29, 2022 04:39
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wonjuleee wonjuleee merged commit 3547c32 into openvinotoolkit:develop Nov 30, 2022
wonjuleee pushed a commit to wonjuleee/datumaro that referenced this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants