-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve mask_to_rle performance #770
Improve mask_to_rle performance #770
Conversation
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportBase: 84.61% // Head: 84.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #770 +/- ##
===========================================
+ Coverage 84.61% 84.67% +0.06%
===========================================
Files 157 157
Lines 22055 22064 +9
Branches 4829 4829
===========================================
+ Hits 18661 18683 +22
+ Misses 2284 2273 -11
+ Partials 1110 1108 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Kim, Vinnam vinnam.kim@intel.com
Summary
pycocotools
and bind it withpybind11
.https://github.com/cocodataset/cocoapi/blob/8c9bcc3cf640524c4c20a9c40e89cb6a2f2fa0e9/common/maskApi.c#L32-L41
pycocotools
.How to test
If the new C-API is compatible with the previous API, our existing unit tests should be passed all.
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.