Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx static type checking #743

Merged
merged 2 commits into from
Oct 18, 2022
Merged

FIx static type checking #743

merged 2 commits into from
Oct 18, 2022

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Oct 17, 2022 •
edited by wonjuleee
Loading

  • Fix wrong typing

Signed-off-by: Kim, Vinnam vinnam.kim@intel.com

Summary

Resolves #737

How to test

It requires static type checker, but we don't have for now.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim
Resolve openvinotoolkit#737
b6dddcf 
 - Fix wrong typing

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added BUG Something isn't working ready-to-review labels Oct 17, 2022
wonjuleee
wonjuleee reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to describe this in Changelog?

@vinnamkim vinnamkim changed the title FIx for #737 FIx static type checking Oct 18, 2022
@vinnamkim
Copy link
Contributor Author

Don't we need to describe this in Changelog?

Updated it.

@vinnamkim
Update CHANGELOG.md
e575a46 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
wonjuleee
wonjuleee approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge this when CI passes

@wonjuleee wonjuleee merged commit 21bd866 into openvinotoolkit:develop Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuneuny-emily chuneuny-emily chuneuny-emily approved these changes

@wonjuleee wonjuleee wonjuleee approved these changes

@sooahleex sooahleex Awaiting requested review from sooahleex

@bonhunko bonhunko Awaiting requested review from bonhunko

Assignees
No one assigned
Labels
BUG Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong annotated return type in Registry class
3 participants
@vinnamkim @chuneuny-emily @wonjuleee