Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.1 #726

Merged

Conversation

chuneuny-emily
Copy link
Contributor

@chuneuny-emily chuneuny-emily commented Sep 5, 2022

Summary

This PR fix

  • CVS-84321 Export Annotated Dataset - lack of image's depth value for VOC dataset
  • CVS-86848 Annotations inside another annotation are duplicated during import for VOC format
  • CVS-85120 Cannot export detection->classification dataset

How to test

  • I performed the existing unit tests locally, and there was no regression on my changes.
  • I performed e2e tests manually, and the issues above were not reproducible anymore.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

CHANGELOG.md Outdated Show resolved Hide resolved
datumaro/components/dataset_filter.py Show resolved Hide resolved
Copy link

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chuneuny-emily chuneuny-emily merged commit 177255a into openvinotoolkit:develop Sep 6, 2022
chuneuny-emily added a commit that referenced this pull request Sep 6, 2022
ET.SubElement(size_elem, "depth").text = ""
depth = ""
if item.media.data is not None:
depth = str(item.media.data.shape[-1])
Copy link
Contributor

@zhiltsov-max zhiltsov-max Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In many cases VOC export is going to take much more time now, because the images have to be loaded. For width and height we often have metainfo in other formats.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images with coco or other formats are not loaded, so item.media.data is None.
It is run when there are the loaded images. If not, it keeps "".

Any suggestion to set depth?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

item.media.data is None only when the image file is not available, but we have metainfo. If you wanted to avoid extra loading, you need to use has_data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Then I will update as using has_data you suggested soon. Do you think it should be included in v0.3.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't answer on this question, release logic is out of my responsibility now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants