Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for empty lines in VOC subset lists #587

Merged
merged 5 commits into from
Dec 21, 2021
Merged

Conversation

yasakova-anastasia
Copy link

@yasakova-anastasia yasakova-anastasia commented Dec 20, 2021

Summary

Fixed the problem #583

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a simple test for this. Even if the fix is simple, it is a problem reported, and we need to make sure we don't break our responsibilities with future changes.

@zhiltsov-max zhiltsov-max merged commit 049dc61 into develop Dec 21, 2021
@zhiltsov-max zhiltsov-max deleted the ay/fix-voc branch December 21, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty lines in VOC subset lists are not ignored
2 participants