Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import for VoTT dataset format #573

Merged
merged 14 commits into from
Dec 7, 2021
Merged

Import for VoTT dataset format #573

merged 14 commits into from
Dec 7, 2021

Conversation

yasakova-anastasia
Copy link

@yasakova-anastasia yasakova-anastasia commented Dec 1, 2021 •
edited
Loading

Summary

Resolved #561

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

zhiltsov-max
zhiltsov-max reviewed Dec 1, 2021
View reviewed changes
tests/assets/vott_json_dataset/dataset/train-export.json Outdated
"format": "jpg",
"id": "0d3de147f",
"name": "img0001.jpg",
"path": "tests/assets/vott_json_dataset/dataset/img0001.jpg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, this path should not contain the leading directories.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What for? If I remove the leading directories, it will break.

Copy link
Contributor

@zhiltsov-max zhiltsov-max Dec 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests/assets/vott_json_dataset/dataset/ part lies outside the dataset root directory, so it definitely must not be be a part of a dataset, it must be computed during loading. Currently it just stores some private information.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@zhiltsov-max
Copy link
Contributor

Please add format docs

@yasakova-anastasia yasakova-anastasia mentioned this pull request Dec 2, 2021
Open
41 tasks
IRDonch
IRDonch suggested changes Dec 3, 2021
View reviewed changes
site/content/en/docs/formats/vott_csv.md Outdated Show resolved Hide resolved
site/content/en/docs/formats/vott_csv.md Outdated Show resolved Hide resolved
datumaro/plugins/vott_csv_format.py Outdated Show resolved Hide resolved
datumaro/plugins/vott_csv_format.py Outdated Show resolved Hide resolved
datumaro/plugins/vott_csv_format.py Outdated Show resolved Hide resolved
datumaro/plugins/vott_csv_format.py Outdated Show resolved Hide resolved
datumaro/plugins/vott_csv_format.py Outdated Show resolved Hide resolved
datumaro/plugins/vott_csv_format.py Outdated Show resolved Hide resolved
datumaro/plugins/vott_json_format.py Outdated Show resolved Hide resolved
datumaro/plugins/vott_json_format.py Outdated Show resolved Hide resolved
@yasakova-anastasia
Copy link
Author

@IRDonch, I think I've fixed everything.

@IRDonch IRDonch merged commit f08353e into develop Dec 7, 2021
@IRDonch IRDonch deleted the ay/vott-format branch December 7, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiltsov-max zhiltsov-max zhiltsov-max left review comments

@IRDonch IRDonch IRDonch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import for VoTT dataset format
3 participants
@yasakova-anastasia @zhiltsov-max @IRDonch