Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coco_format: add an option to preserve original category IDs when extracting #453

Merged
merged 3 commits into from
Sep 9, 2021
Merged

coco_format: add an option to preserve original category IDs when extracting #453

merged 3 commits into from
Sep 9, 2021

Conversation

IRDonch
Copy link

@IRDonch IRDonch commented Sep 8, 2021

Summary

This is needed for potential integration into Accuracy Checker, since AC has this option as well.

As a side effect, refactor the loading of categories to remove duplication between the panoptic segmentation and other task types.

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use more short "keep" instead of "preserve".

Update the format documentation.

@IRDonch IRDonch marked this pull request as draft September 8, 2021 16:15
Roman Donchenko added 2 commits September 8, 2021 20:10
…racting

This is needed for potential integration into Accuracy Checker, since AC has
this option as well.

As a side effect, refactor the loading of categories to remove duplication
between the panoptic segmentation and other task types.
@IRDonch
Copy link
Author

IRDonch commented Sep 8, 2021

I suggest to use more short "keep" instead of "preserve".

Okay, done.

Update the format documentation.

I would, but there's no documentation for the importer/extractor API in the first place.

@zhiltsov-max
Copy link
Contributor

I would, but there's no documentation for the importer/extractor API in the first place.

How it hinders to describing import parameters in the format documentation? There is nothing about API at all.

@IRDonch
Copy link
Author

IRDonch commented Sep 9, 2021

The parameter currently only exists on the API level. Should I add a corresponding CLI option?

@zhiltsov-max
Copy link
Contributor

IMO, there's a little sense, if it is an API-only parameter. Maybe, I'd invest in auto-generation of cli parsers from the ctor parameters, but not now.

@IRDonch IRDonch marked this pull request as ready for review September 9, 2021 14:03
@IRDonch
Copy link
Author

IRDonch commented Sep 9, 2021

OK, I added a CLI option equivalent and documented it.

@zhiltsov-max zhiltsov-max merged commit 494950a into openvinotoolkit:develop Sep 9, 2021
@IRDonch IRDonch deleted the coco-preserve-original-cat-ids branch September 9, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants