Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and simplify plugins #22

Merged
merged 8 commits into from
Oct 1, 2020
Merged

Refactor and simplify plugins #22

merged 8 commits into from
Oct 1, 2020

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Sep 21, 2020 •
edited
Loading

Summary

  • Extracted common code for Importers, Transforms, Extractors, removed unnecessary code
  • Improved caching in transforms. Creation of a transform could led to unnecessary source dataset traversal with corresponding performance consequences
  • Dataset class moved to its own file
  • All DatasetItems and Extractors now use default subset name default instead of None. These values are interchangeable

How to test

Unit tests

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max zhiltsov-max merged commit 48105f1 into develop Oct 1, 2020
@zhiltsov-max zhiltsov-max deleted the zm/refactor-plugins branch October 1, 2020 14:29
This was referenced Oct 5, 2020
Merged
Merged
zhiltsov-max pushed a commit that referenced this pull request Oct 5, 2020
Release v0.1.2
86f7f6b 
Added:
- `ByteImage` class to represent encoded images in memory and avoid recoding on save (<#27>)

Changed:
- Implementation of format plugins simplified (<#22>)
- `default` is now a default subset name, instead of `None`. The values are interchangeable. (<#22>)
- Improved performance of transforms (<#22>)

Removed:
- `image/depth` value from VOC export (<#27>)

Fixed:
- Zero division errors in dataset statistics (<#31>)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhiltsov-max