Improve get_area() for polygons through Shoelace formula #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## releases/1.7.0 #1507 +/- ##
=================================================
Coverage ? 80.77%
=================================================
Files ? 275
Lines ? 31514
Branches ? 6358
=================================================
Hits ? 25456
Misses ? 4644
Partials ? 1414
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vinnamkim
reviewed
May 28, 2024
| @@ -812,11 +812,12 @@ def __attrs_post_init__(self): | |||
| ) | |||
|
|
|||
| def get_area(self): | |||
| import pycocotools.mask as mask_utils | |||
| # import pycocotools.mask as mask_utils | |||
There was a problem hiding this comment.
Suggested change
| # import pycocotools.mask as mask_utils |
vinnamkim
reviewed
May 28, 2024
Comment on lines
+817
to
+819
| # x, y, w, h = self.get_bbox() | ||
| # rle = mask_utils.frPyObjects([self.points], y + h, x + w) | ||
| # area = mask_utils.area(rle)[0] |
There was a problem hiding this comment.
Suggested change
| # x, y, w, h = self.get_bbox() | |
| # rle = mask_utils.frPyObjects([self.points], y + h, x + w) | |
| # area = mask_utils.area(rle)[0] |
vinnamkim
reviewed
May 28, 2024
| @@ -842,6 +843,21 @@ def __eq__(self, other): | |||
| inter_area = self_polygon.intersection(other_polygon).area | |||
| return abs(self_polygon.area - inter_area) < CHECK_POLYGON_EQ_EPSILONE | |||
|
|
|||
| def _get_shoelace_area(self): | |||
There was a problem hiding this comment.
@sooahleex
If you are still interested in Rust, porting this Python function into Rust would be a good starting point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
about 25 times faster computation compared to previous RLE mask based area computation
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.