Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the color channel format (RGB) for datum stats command #1389

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Mar 28, 2024

Summary

  • Ticket no. 137105 and GH issue datum stats output format  #1367
  • Print the color channel format as well (RGB)
  • Change the statistic accumulation logic to use ImageColorChannel context

How to test

Revisit the unit test as well to cover this change

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim vinnamkim requested review from a team as code owners March 28, 2024 02:56
@vinnamkim vinnamkim requested review from sooahleex and removed request for a team March 28, 2024 02:56
 - Print the color channel format as well (RGB)
 - Change the statistic accumulation logic to use ImageColorChannel context

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim changed the title Revisit compute_image_statistics Print the color channel format (RGB) for datum stats command Mar 28, 2024
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (releases/2.0.0@26f95ed). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                @@
##             releases/2.0.0    #1389   +/-   ##
=================================================
  Coverage                  ?   80.82%           
=================================================
  Files                     ?      270           
  Lines                     ?    30668           
  Branches                  ?     6198           
=================================================
  Hits                      ?    24788           
  Misses                    ?     4491           
  Partials                  ?     1389           
Flag Coverage Δ
windows-2022_Python-3.10 80.82% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wonjuleee wonjuleee merged commit b0aa439 into openvinotoolkit:releases/2.0.0 Mar 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants