Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DatasetImportError for yolo variants #1362

Merged

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Mar 20, 2024

Summary

Datumaro is able to import a dataset from extractor directly as described in

elif format in env.extractors:

However, in this case, we have to be careful for importing a dataset.
For instance, Yolo extractors, i.e., YoloLooseBase, YoloUltralyticsBase, RoboflowYoloBase, and RoboflowYoloObbBase, require to have urls for specifying subset and all annotation files accordingly.

In this PR, I have added DatasetImportError when importing a Yolo dataset without urls.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners March 20, 2024 02:47
@wonjuleee wonjuleee requested review from sooahleex and vinnamkim and removed request for a team March 20, 2024 02:47
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (releases/2.0.0@b29b8c3). Click here to learn what that means.

Files Patch % Lines
src/datumaro/plugins/data_formats/yolo/base.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             releases/2.0.0    #1362   +/-   ##
=================================================
  Coverage                  ?   80.85%           
=================================================
  Files                     ?      271           
  Lines                     ?    30689           
  Branches                  ?     6197           
=================================================
  Hits                      ?    24814           
  Misses                    ?     4489           
  Partials                  ?     1386           
Flag Coverage Δ
ubuntu-20.04_Python-3.10 80.84% <0.00%> (?)
windows-2022_Python-3.10 80.83% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wonjuleee wonjuleee force-pushed the unknown_format_error branch 2 times, most recently from 7edfe93 to dfe2bc0 Compare March 20, 2024 04:39
@wonjuleee wonjuleee merged commit 5962edf into openvinotoolkit:releases/2.0.0 Mar 20, 2024
8 checks passed
@yunchu yunchu added this to the 2.0.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants